★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/32348Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: ICU 66.1 #32348

Closed
wants to merge 0 commits into from
Closed

deps: ICU 66.1 #32348

wants to merge 0 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 18, 2020 •
edited

It's that time again…  Prior PR: #30232 for 65.2

By the way, this is a very small focussed release of ICU—just Unicode 13 and selected patches.

@srl295 srl295 added i18n-api dependencies labels Mar 18, 2020
@srl295 srl295 requested review from richardlau and ryzokuken Mar 18, 2020
@srl295 srl295 self-assigned this Mar 18, 2020
@nodejs-github-bot nodejs-github-bot added the meta label Mar 18, 2020
@srl295 srl295 marked this pull request as ready for review Mar 18, 2020
@srl295
Copy link
Member Author

@srl295 srl295 commented Mar 18, 2020

See also #32347 (not required to land this)

@srl295 srl295 requested a review from devsnek Mar 18, 2020
ryzokuken
ryzokuken approved these changes Mar 18, 2020
View changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Thanks!

@richardlau richardlau added the notable-change label Mar 18, 2020
jasnell
jasnell approved these changes Mar 18, 2020
View changes
Copy link
Member

@jasnell jasnell left a comment

Rubber stamp LGTM

mhdawson
mhdawson approved these changes Mar 19, 2020
View changes
Copy link
Member

@mhdawson mhdawson left a comment

Rubber stamp LGTM

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 19, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29935/

srl295 added a commit that referenced this issue Mar 21, 2020
@srl295
deps: update to ICU 66.1
74e7e72 
- ICU 66.1 http://site.icu-project.org/download/66
- Unicode 13
- CLDR 36.1
- Updated ./LICENSE

PR-URL: #32348
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295 srl295 closed this Mar 21, 2020
@srl295
Copy link
Member Author

@srl295 srl295 commented Mar 21, 2020

Landed in 74e7e72

@srl295 srl295 deleted the icu-66.1 branch Mar 21, 2020
@srl295
Copy link
Member Author

@srl295 srl295 commented Mar 21, 2020

fyi @nodejs/i18n @nodejs/i18n-api

MylesBorins pushed a commit that referenced this issue Mar 24, 2020
@srl295 @MylesBorins
deps: update to ICU 66.1
2cb9f7a 
- ICU 66.1 http://site.icu-project.org/download/66
- Unicode 13
- CLDR 36.1
- Updated ./LICENSE

PR-URL: #32348
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
@targos targos added the backport-requested-v12.x label Apr 22, 2020
@targos
Copy link
Member

@targos targos commented Apr 22, 2020

Please open a backport PR for v12.x-staging

@targos targos added dont-land-on-v12.x and removed backport-requested-v12.x labels May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@richardlau richardlau

@mhdawson mhdawson

@ryzokuken ryzokuken

@devsnek devsnek

Assignees

@srl295 srl295

Labels
dependencies dont-land-on-v12.x i18n-api meta notable-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@srl295 @nodejs-github-bot @targos @jasnell @richardlau @mhdawson @ryzokuken