★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/32151Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move inactive collaborators to emeriti #32151

Merged
merged 1 commit into from Mar 12, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 8, 2020

I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

@claudiorodriguez @iarna @italoacasas @MoonBall @rubys @seishun @trevnorris If any of you wish to remain collaborators for any reason whatsoever, just let me know in the next 72 hours and I'll remove you from this PR. (You don't even have to tell me what the reason is. Leave a comment here or send me an email.)

Thanks for all the great contributions and collaboration over the years!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc label Mar 8, 2020
@Trott Trott added the author ready label Mar 9, 2020
trivikr
trivikr approved these changes Mar 9, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Mar 10, 2020

Copy link
Member

@mcollina mcollina left a comment

lgtm

@rubys
Copy link
Member

@rubys rubys commented Mar 10, 2020

I wish to remain a collaborator.

@Trott Trott removed the author ready label Mar 10, 2020
jasnell
jasnell previously requested changes Mar 10, 2020
Copy link
Member

@jasnell jasnell left a comment

Given @rubys' request to remain, just making the -1 explicit until the PR is updated to reflect that.

@Trott Trott dismissed jasnell’s stale review Mar 11, 2020

Restored rubys

@Trott Trott added the author ready label Mar 11, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Mar 11, 2020

@seishun sent me an email saying they want to remain a collaborator, so I'll update this....

@Trott Trott removed the author ready label Mar 11, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Mar 12, 2020

Restored @seishun. This should be ready to land. One more approval or re-approval for good measure would be great.

Copy link
Member

@MylesBorins MylesBorins left a comment

LGTM

so long and thanks for all the commits

I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Trott Trott merged commit e6a55b4 into nodejs:master Mar 12, 2020
17 of 18 checks passed
@Trott
Copy link
Member Author

@Trott Trott commented Mar 12, 2020

Landed in e6a55b4

@Trott Trott deleted the emeritus-mar-2020 branch Mar 12, 2020
BridgeAR added a commit that referenced this issue Mar 17, 2020
I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
MylesBorins added a commit that referenced this issue Mar 24, 2020
I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos added a commit that referenced this issue Apr 22, 2020
I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants