test: mark empty udp tests flaky on OS X #31936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: nodejs#30030 Refs: nodejs/build#2189 (comment)
|
I don't have access to a machine I can repro this on, but I asked @AshCripps to try it (nodejs/build#2189 (comment)). @lpinca , perhaps you can review, too? |
|
I've run |
|
Oh, I forgot to use the |
lpinca
approved these changes
Feb 25, 2020
BethGriggs
approved these changes
Feb 25, 2020
|
@AshCripps would it be helpful to get this fast-tracked? I kicked of a full CI on it, but it still needs 25 hours, but we can fast-track given its triviality and impact on CI stability if its blocking bringing the OS X 10.15/Catalina machines into CI. |
jasnell
approved these changes
Feb 25, 2020
|
@sam-github Fast track would be useful, pretty sure every release line will fail these tests when 10.15 is added to CI |
|
@nodejs/build @nodejs/testing Can we fast-track marking these tests flaky? |
|
Btw, the build status reported is incorrect - PR passed on everything but arm, as would be expected. I kicked a resume on the PR, though. |
rvagg
approved these changes
Feb 26, 2020
|
Landed in 24a4f76 |
sam-github
added a commit
that referenced
this issue
Feb 26, 2020
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: #30030 Refs: nodejs/build#2189 (comment) PR-URL: #31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
BethGriggs
pushed a commit
that referenced
this issue
Feb 27, 2020
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: #30030 Refs: nodejs/build#2189 (comment) PR-URL: #31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
codebytere
pushed a commit
that referenced
this issue
Feb 27, 2020
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: #30030 Refs: nodejs/build#2189 (comment) PR-URL: #31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Merged
4 tasks
puzpuzpuz
pushed a commit
to puzpuzpuz/node
that referenced
this issue
Mar 8, 2020
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: nodejs#30030 Refs: nodejs/build#2189 (comment) PR-URL: nodejs#31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
3 tasks
Merged
codebytere
pushed a commit
that referenced
this issue
Mar 14, 2020
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: #30030 Refs: nodejs/build#2189 (comment) PR-URL: #31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> PR-URL: #32146 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.
Refs: #30030
Refs: nodejs/build#2189 (comment)
Note: CI doesn't test on Catalina, yet (though I assume nodejs developers do). Test failures will indirectly block fixing of #29216, which requires running notarization on Catalina, which requires tests passing on Catalina.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes