crypto: make DH error messages consistent #31873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 19, 2020
devnexen
approved these changes
Feb 19, 2020
lpinca
approved these changes
Feb 19, 2020
|
Since this is not changing the error code and only touches the error message, it does not need to be semver-major |
jasnell
approved these changes
Feb 19, 2020
|
Ah, ok. That original pr should have been semver major |
|
Mhh really? I talked to another collaborator before creating the PR, and we came to the conclusion that adding a code (as opposed to changing an existing code) isn't breaking behavior, because it is unrealistic that existing code relies on the non-existence of the code property. |
bnoordhuis
approved these changes
Feb 20, 2020
cjihrig
approved these changes
Feb 20, 2020
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
BridgeAR
approved these changes
Mar 9, 2020
|
CitGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2297 Looks normal to me, then again, I find it very difficult to get meaningful information from the failures. |
addaleax
added a commit
that referenced
this issue
Mar 11, 2020
Refs: #31178 Refs: #31445 PR-URL: #31873 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 1b9a62c |
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This custom error message was only added to make sure that #31445 was semver-minor.
Refs: #31178
Refs: #31445
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes