★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/31753Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] deps: V8: cherry-pick d89f4ef1cd62 #31753

Closed
wants to merge 1 commit into from
Closed

[v10.x] deps: V8: cherry-pick d89f4ef1cd62 #31753

wants to merge 1 commit into from

Conversation

@miladfarca
Copy link
Contributor

@miladfarca miladfarca commented Feb 12, 2020

Original commit message:

S390x: improve performance by skipping Debug Hook if not needed

Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#65644}

Refs: v8/v8@d89f4ef

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
[v10.x] deps: V8: cherry-pick d89f4ef1cd62
d7371db
@miladfarca
Copy link
Contributor Author

@miladfarca miladfarca commented Feb 12, 2020

/cc @nodejs/platform-s390

@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Feb 26, 2020 •
edited by BethGriggs

CI: https://ci.nodejs.org/job/node-test-pull-request/29371/ ✅

@BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Feb 26, 2020

Landed in 9b2b66b

@BethGriggs BethGriggs closed this Feb 26, 2020
BethGriggs pushed a commit that referenced this issue Feb 26, 2020
@BethGriggs
deps: V8: cherry-pick d89f4ef1cd62
9b2b66b 
PR-URL: #31753
Refs: v8/v8@d89f4ef
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-yan john-yan

@bnoordhuis bnoordhuis

@richardlau richardlau

@BethGriggs BethGriggs

Assignees
No one assigned
Labels
build v8 engine
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@miladfarca @nodejs-github-bot @BethGriggs @bnoordhuis @john-yan @richardlau