★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/31175Nouvelle recherche | Portail wanayoo
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: use let instead of var in dgram #31175

Closed
wants to merge 1 commit into from
Closed

benchmark: use let instead of var in dgram #31175

wants to merge 1 commit into from
+17 −18

Conversation

@dnlup
Copy link
Contributor

dnlup commented Jan 3, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@dnlup
benchmark: use let instead of var in dgram
Loading status checks…
8c3a5a2
@BridgeAR
BridgeAR approved these changes Jan 3, 2020
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Jan 3, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28156/
@Trott
Trott approved these changes Jan 4, 2020
View changes
@trivikr
trivikr approved these changes Jan 4, 2020
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Jan 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28196/
@devnexen
devnexen approved these changes Jan 5, 2020
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Jan 6, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28227/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Jan 6, 2020

Landed in 57a1ca9
@Trott Trott closed this Jan 6, 2020
Trott added a commit that referenced this pull request Jan 6, 2020
@dnlup @Trott
benchmark: use let instead of var in dgram
Loading status checks…
57a1ca9 
PR-URL: #31175
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos added a commit that referenced this pull request Jan 6, 2020
@dnlup @targos
benchmark: use let instead of var in dgram
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
5fccb50 
PR-URL: #31175
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@dnlup dnlup deleted the dnlup:benchmark_dgram branch Jan 6, 2020
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos added a commit that referenced this pull request Jan 14, 2020
@dnlup @targos
benchmark: use let instead of var in dgram
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c5a4a39 
PR-URL: #31175
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
@dnlup @targos
benchmark: use let instead of var in dgram
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
4ee5665 
PR-URL: #31175
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@dnlup @BethGriggs
benchmark: use let instead of var in dgram
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
634389b 
PR-URL: #31175
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
saitonakamura pushed a commit to saitonakamura/node that referenced this pull request Apr 7, 2020
@dnlup Michael Bashurov
benchmark: use let instead of var in dgram
c8d25ef 
PR-URL: nodejs#31175
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@devnexen devnexen

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
author ready benchmark dgram
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@dnlup @nodejs-github-bot @Trott @devnexen @BridgeAR @trivikr
You can’t perform that action at this time.