★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/31085Nouvelle recherche | Portail wanayoo
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update parameters for chmod and chmodsync #31085

Closed
wants to merge 1 commit into from
Closed

docs: update parameters for chmod and chmodsync #31085

wants to merge 1 commit into from

Conversation

@santoshyadav198613
Copy link
Contributor

santoshyadav198613 commented Dec 24, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@gireeshpunathil
gireeshpunathil approved these changes Dec 25, 2019
View changes
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Dec 25, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4114/
@Trott
Trott approved these changes Dec 25, 2019
View changes
@Trott Trott added the author ready label Dec 25, 2019
@jasnell
jasnell approved these changes Dec 26, 2019
View changes
@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:patch-1 branch Dec 26, 2019
@santoshyadav198613

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

santoshyadav198613 commented Dec 26, 2019

Thank you team, I have made the changes in commit message.
@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:patch-1 branch Dec 26, 2019
@devnexen devnexen force-pushed the nodejs:master branch from bdb1194 to 5289f80 Dec 26, 2019
@trivikr
trivikr approved these changes Dec 27, 2019
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 27, 2019

@santoshyadav198613 Can you update the commit message to include a subsystem, a better description in the header, and punctuation in the body? If you just want to copy/paste, here's what I would recommend:

doc: update parameter type for fs.chmod()

The mode parameter of fs.chmod() and fs.chmodSync() can be a string or 
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.
@Trott Trott removed the author ready label Dec 27, 2019
@santoshyadav198613
doc: update parameter type for fs.chmod()
Loading status checks…
c935580 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.
@Trott Trott force-pushed the santoshyadav198613:patch-1 branch Dec 27, 2019
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 27, 2019

doc: update parameter type for fs.chmod()

The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Never mind. I made the edits myself and pushed it to the branch.
@Trott Trott added the author ready label Dec 27, 2019
@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:patch-1 branch to c935580 Dec 27, 2019
@santoshyadav198613

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

santoshyadav198613 commented Dec 27, 2019

doc: update parameter type for fs.chmod()
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Never mind. I made the edits myself and pushed it to the branch.

Sorry I also pushed the same changes.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 27, 2019

Sorry I also pushed the same changes.

Ha ha! Yeah, no problem. Thanks!
@Trott
Trott approved these changes Dec 27, 2019
View changes
@santoshyadav198613

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

santoshyadav198613 commented Dec 27, 2019

Sorry I also pushed the same changes.

Ha ha! Yeah, no problem. Thanks!

Thanks, this was my first PR sorry for the trouble.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 27, 2019

Landed in 283e7a4.

Thanks for the contribution! 🎉
@Trott Trott closed this Dec 27, 2019
Trott added a commit to Trott/io.js that referenced this pull request Dec 27, 2019
@santoshyadav198613 @Trott
doc: update parameter type for fs.chmod()
283e7a4 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: nodejs#31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig added a commit to cjihrig/node that referenced this pull request Dec 27, 2019
@cjihrig
doc: update parameter type for fsPromises.chmod()
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
08064f3 
This was overlooked in nodejs#31085.
@cjihrig cjihrig mentioned this pull request Dec 27, 2019
Closed
3 of 3 tasks complete
Trott added a commit that referenced this pull request Dec 29, 2019
@cjihrig @Trott
doc: update parameter type for fsPromises.chmod()
ba4d68c 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
@santoshyadav198613 @BridgeAR
doc: update parameter type for fs.chmod()
Unverified
The committer email address is not verified.
Learn about signing commits
4c29a6e 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
@cjihrig @BridgeAR
doc: update parameter type for fsPromises.chmod()
Unverified
The committer email address is not verified.
Learn about signing commits
6855788 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos added a commit that referenced this pull request Jan 14, 2020
@santoshyadav198613 @targos
doc: update parameter type for fs.chmod()
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
671a5b7 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
@cjihrig @targos
doc: update parameter type for fsPromises.chmod()
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
54cbbae 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@santoshyadav198613 @BethGriggs
doc: update parameter type for fs.chmod()
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
a192afc 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@cjihrig @BethGriggs
doc: update parameter type for fsPromises.chmod()
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
13fe137 
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
saitonakamura pushed a commit to saitonakamura/node that referenced this pull request Apr 7, 2020
@santoshyadav198613 Michael Bashurov
doc: update parameter type for fs.chmod()
3257b8d 
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: nodejs#31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
saitonakamura pushed a commit to saitonakamura/node that referenced this pull request Apr 7, 2020
@cjihrig Michael Bashurov
doc: update parameter type for fsPromises.chmod()
b7f72a1 
This was overlooked in nodejs#31085.

PR-URL: nodejs#31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@gireeshpunathil gireeshpunathil

@trivikr trivikr

Assignees
No one assigned
Labels
author ready doc fs
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@santoshyadav198613 @gireeshpunathil @Trott @jasnell @trivikr @nodejs-github-bot
You can’t perform that action at this time.