★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/31047Nouvelle recherche | Portail wanayoo
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgram: test to add and to drop specific membership #31047

Closed
wants to merge 2 commits into from
Closed

dgram: test to add and to drop specific membership #31047

wants to merge 2 commits into from

Conversation

@zeroWheel
Copy link
Contributor

zeroWheel commented Dec 20, 2019

Code and learn task for additional coverage for situation when
methods addSourceSpecificMembership and dropSourceSpecificMembership of the dgram module
called with incorrect sourceAddress and groupAddress arguments.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
zeroWheel added 2 commits Dec 20, 2019
@zeroWheel
dgram: test to add and to drop specific membership
3abcdf4 
Test of addSourceSpecificMembership and dropSourceSpecificMembership
for correct arguments with sourceAddress, groupAddress.
@zeroWheel
test: fix linters and messages of tests
Loading status checks…
0559d2c 
Fix max-len and assert.throws message
@zeroWheel zeroWheel force-pushed the zeroWheel:lib-dgram-membership-throw branch to 0559d2c Dec 20, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Dec 20, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27840/
@addaleax
addaleax approved these changes Dec 21, 2019
View changes
@Trott
Trott approved these changes Dec 21, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Dec 21, 2019 •
edited by BridgeAR

CI: https://ci.nodejs.org/job/node-test-pull-request/27844/ ✔️
@BridgeAR
BridgeAR approved these changes Dec 21, 2019
View changes
@cjihrig
cjihrig approved these changes Dec 21, 2019
View changes
@lpinca
lpinca approved these changes Dec 21, 2019
View changes
BridgeAR added a commit that referenced this pull request Dec 25, 2019
@zeroWheel @BridgeAR
dgram: test to add and to drop specific membership
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
643241a 
Test of addSourceSpecificMembership and dropSourceSpecificMembership
for correct arguments with sourceAddress, groupAddress.

PR-URL: #31047
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Dec 25, 2019

Landed in 643241a

@zeroWheel congratulations to your first commit to Node.js! 🎉 This is an awesome first contribution!
@BridgeAR BridgeAR closed this Dec 25, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
@zeroWheel @BridgeAR
dgram: test to add and to drop specific membership
Unverified
The committer email address is not verified.
Learn about signing commits
44d03e8 
Test of addSourceSpecificMembership and dropSourceSpecificMembership
for correct arguments with sourceAddress, groupAddress.

PR-URL: #31047
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos added a commit that referenced this pull request Jan 14, 2020
@zeroWheel @targos
dgram: test to add and to drop specific membership
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6d6a480 
Test of addSourceSpecificMembership and dropSourceSpecificMembership
for correct arguments with sourceAddress, groupAddress.

PR-URL: #31047
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
@zeroWheel @targos
dgram: test to add and to drop specific membership
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
83f8939 
Test of addSourceSpecificMembership and dropSourceSpecificMembership
for correct arguments with sourceAddress, groupAddress.

PR-URL: #31047
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@zeroWheel @BethGriggs
dgram: test to add and to drop specific membership
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
25d96ec 
Test of addSourceSpecificMembership and dropSourceSpecificMembership
for correct arguments with sourceAddress, groupAddress.

PR-URL: #31047
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
saitonakamura pushed a commit to saitonakamura/node that referenced this pull request Apr 7, 2020
@zeroWheel Michael Bashurov
dgram: test to add and to drop specific membership
ba8ac47 
Test of addSourceSpecificMembership and dropSourceSpecificMembership
for correct arguments with sourceAddress, groupAddress.

PR-URL: nodejs#31047
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@addaleax addaleax

@lpinca lpinca

@cjihrig cjihrig

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready code-and-learn dgram
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@zeroWheel @nodejs-github-bot @BridgeAR @Trott @addaleax @lpinca @cjihrig
You can’t perform that action at this time.