Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbenchmark: use let instead of var in child_process #31043
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
You can work around the error in the benchmark by explicitly allowing zeroes with an environment variable: NODEJS_BENCHMARK_ZERO_ALLOWED=1 node benchmark/run.js child_process |
This comment has been minimized.
This comment has been minimized.
|
Also, if you don't actually care to run all the benchmarks and just want a quick test that your changes didn't break anything obvious: node test/benchmark/test-benchmark-child-process.js |
This comment has been minimized.
This comment has been minimized.
|
Thanks @Trott . |
BridgeAR
added a commit
that referenced
this pull request
Dec 25, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 3885e15 |
BridgeAR
added a commit
that referenced
this pull request
Jan 3, 2020
Merged
targos
added a commit
that referenced
this pull request
Jan 14, 2020
BethGriggs
added a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #31043 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
saitonakamura
pushed a commit
to saitonakamura/node
that referenced
this pull request
Apr 7, 2020
PR-URL: nodejs#31043 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dnlup commentedDec 20, 2019
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesI am getting this error here when running benchmarks though:
I ran the benchmark with: