Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upconsole: unregister temporary error listener #30852
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
Is it worthwhile to write a test for this? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in d64c1dc |
Trott
added a commit
that referenced
this pull request
Dec 14, 2019
MylesBorins
added a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30852 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
added a commit
that referenced
this pull request
Jan 14, 2020
BethGriggs
added a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30852 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
saitonakamura
pushed a commit
to saitonakamura/node
that referenced
this pull request
Apr 7, 2020
PR-URL: nodejs#30852 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ronag commentedDec 8, 2019
I think the idea here was to swallow ONE error. Not sure if this actually makes any difference. Can the stream be re-used after having errored?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes