★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/30641Nouvelle recherche | Portail wanayoo
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: automatically manage memory for ECDSA_SIG #30641

Closed
wants to merge 1 commit into from
Closed

crypto: automatically manage memory for ECDSA_SIG #30641

wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

tniessen commented Nov 25, 2019

As suggested by @bnoordhuis in #29292.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@tniessen
crypto: automatically manage memory for ECDSA_SIG
Loading status checks…
ee56100 
Refs: #29292
@cjihrig
cjihrig approved these changes Nov 25, 2019
View changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
Copy link

nodejs-github-bot commented Nov 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26988/
@devnexen
devnexen approved these changes Nov 26, 2019
View changes
@bnoordhuis
bnoordhuis approved these changes Nov 26, 2019
View changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
Copy link

nodejs-github-bot commented Nov 26, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27036/
@addaleax
addaleax approved these changes Nov 27, 2019
View changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
Copy link

nodejs-github-bot commented Nov 27, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27105/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Nov 29, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27180/
addaleax added a commit that referenced this pull request Nov 30, 2019
@tniessen @addaleax
crypto: automatically manage memory for ECDSA_SIG
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
f6a4a36 
Refs: #29292

PR-URL: #30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 30, 2019

Landed in f6a4a36
@addaleax addaleax closed this Nov 30, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
@tniessen @addaleax
crypto: automatically manage memory for ECDSA_SIG
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
4affc30 
Refs: #29292

PR-URL: #30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos added a commit that referenced this pull request Jan 13, 2020
@tniessen @targos
crypto: automatically manage memory for ECDSA_SIG
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
2e06b85 
Refs: #29292

PR-URL: #30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Jan 15, 2020
Closed
@tniessen tniessen deleted the tniessen:crypto-use-automatic-memory-management-for-ecdsasig branch Jan 23, 2020
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@tniessen @BethGriggs
crypto: automatically manage memory for ECDSA_SIG
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
dd118b7 
Refs: #29292

PR-URL: #30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
saitonakamura pushed a commit to saitonakamura/node that referenced this pull request Apr 7, 2020
@tniessen Michael Bashurov
crypto: automatically manage memory for ECDSA_SIG
b680001 
Refs: nodejs#29292

PR-URL: nodejs#30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@addaleax addaleax

@cjihrig cjihrig

@devnexen devnexen

Assignees
No one assigned
Labels
C++ author ready crypto
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@tniessen @nodejs-github-bot @addaleax @bnoordhuis @cjihrig @devnexen
You can’t perform that action at this time.