★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/30379Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: replace var with let #30379

Closed
wants to merge 1 commit into from
Closed

stream: replace var with let #30379

wants to merge 1 commit into from

Conversation

daern91
Copy link
Contributor

@daern91 daern91 commented Nov 12, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax addaleax added code-and-learn stream labels Nov 12, 2019
@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Nov 13, 2019

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4069/

@BridgeAR BridgeAR added the author ready label Nov 13, 2019
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26586/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26660/

gireeshpunathil pushed a commit that referenced this issue Nov 18, 2019
@daern91 @gireeshpunathil
stream: replace var with let
411c1a6 
PR-URL: #30379
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Nov 18, 2019

landed in 411c1a6 , thanks for the contribution!

BridgeAR pushed a commit that referenced this issue Nov 19, 2019
@daern91 @BridgeAR
stream: replace var with let
4524c7a 
PR-URL: #30379
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this issue Dec 1, 2019
@daern91 @targos
stream: replace var with let
f212dd9 
PR-URL: #30379
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this issue Dec 17, 2019
@daern91 @MylesBorins
stream: replace var with let
8792147 
PR-URL: #30379
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
author ready code-and-learn stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@daern91 @BridgeAR @nodejs-github-bot @gireeshpunathil @jasnell @addaleax @trivikr