Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: esm: improve dual package hazard docs #30345
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
What I'm looking for specifically is a note like -
|
This comment has been minimized.
This comment has been minimized.
|
The problem specifically is that the break is not visible in testing, and will only become obvious much further down the line. |
doc/api/esm.md
Outdated
Show resolved
Hide resolved
robpalme left a comment
|
Minor wording suggestions. |
doc/api/esm.md
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MylesBorins
added a commit
that referenced
this pull request
Nov 17, 2019
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
landed in d9efc7d |
MylesBorins
added a commit
that referenced
this pull request
Nov 17, 2019
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Merged
MylesBorins
added a commit
that referenced
this pull request
Jan 12, 2020
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
BethGriggs
added a commit
that referenced
this pull request
Feb 6, 2020
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Merged
saitonakamura
pushed a commit
to saitonakamura/node
that referenced
this pull request
Apr 7, 2020
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: nodejs#30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
GeoffreyBooth commentedNov 9, 2019
•
edited
This updates the ES modules docs regarding hazards related to dual packages per the findings in nodejs/modules#409. Basically, the hazard that we previously thought was isolated to divergent specifiers (e.g.
'pkg'resolving toindex.cjsfor CommonJS andindex.mjsfor ESM) happens for all dual packages even if the two entry points are at different specifiers (e.g.'pkg'and'pkg/module'). Therefore the section on writing dual packages applies not just to conditional exports but to the ES modules implementation generally.Follow up to #30051.
cc @guybedford @MylesBorins @nodejs/modules-active-members
Checklist