★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/30295Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: test configure ninja" #30295

Closed
wants to merge 1 commit into from
Closed

Revert "test: test configure ninja" #30295

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Nov 6, 2019

This reverts commit 85dd9e8.

make test should never change the current set of configure
flags.

Refs: #30033

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
Revert "test: test configure ninja"
87aac3f 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: nodejs#30033
@addaleax
Copy link
Member Author

@addaleax addaleax commented Nov 6, 2019

Please 👍 this comment to approve fast-tracking, even without a full CI run.

This currently breaks ./configure with flags other than --ninja and makes the full Node.js build run twice (once without ninja, once with) when e.g. compiling addon tests.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26401/

@addaleax
Copy link
Member Author

@addaleax addaleax commented Nov 6, 2019

Landed in 3698031, thanks for the quick reviews!

@addaleax addaleax closed this Nov 6, 2019
addaleax added a commit that referenced this issue Nov 6, 2019
@addaleax
Revert "test: test configure ninja"
3698031 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: #30033

PR-URL: #30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@addaleax addaleax deleted the revert-30033 branch Nov 6, 2019
MylesBorins added a commit that referenced this issue Nov 17, 2019
@addaleax @MylesBorins
Revert "test: test configure ninja"
8fe6849 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: #30033

PR-URL: #30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen

@richardlau richardlau

Assignees
No one assigned
Labels
build dont-land-on-v12.x fast-track
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
5 participants
@addaleax @nodejs-github-bot @gengjiawen @richardlau @targos