★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/29982Nouvelle recherche | Portail wanayoo
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update remark-preset-lint-node to 1.10.1 #29982

Merged
merged 2 commits into from Oct 15, 2019
Merged

tools: update remark-preset-lint-node to 1.10.1 #29982

merged 2 commits into from Oct 15, 2019

Conversation

@Trott
Copy link
Member

Trott commented Oct 15, 2019

This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks @nschonni!).

Update other dependencies while at it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Oct 15, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3993/
@BridgeAR
BridgeAR approved these changes Oct 15, 2019
View changes
@cjihrig
cjihrig approved these changes Oct 15, 2019
View changes
@nschonni nschonni mentioned this pull request Oct 15, 2019
Merged
@Trott Trott added the author ready label Oct 15, 2019
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Oct 15, 2019

I don't want lint violations to land in the docs while this waits for the 48 hours, so I'd like to fast track. Collaborators, please 👍 here to approve.
@Trott Trott added the fast-track label Oct 15, 2019
@richardlau
richardlau approved these changes Oct 15, 2019
View changes
@lpinca
lpinca approved these changes Oct 15, 2019
View changes
Trott added 2 commits Oct 15, 2019
@Trott
doc: update vm.md for link linting
c4de76f 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
tools: update remark-preset-lint-node to 1.10.1
Loading status checks…
90b5f1b 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the Trott:update-preset-to-1.10.1 branch to 90b5f1b Oct 15, 2019
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Oct 15, 2019

Landed in f4f856b...90b5f1b
@Trott Trott merged commit 90b5f1b into nodejs:master Oct 15, 2019
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2019
Merged
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 8, 2019

Depends on #29864 to land on v12.x.
aduh95 added a commit to aduh95/node that referenced this pull request Jan 7, 2020
@Trott @aduh95
doc: update vm.md for link linting
adf9fe0 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Jan 7, 2020
@Trott @aduh95
tools: update remark-preset-lint-node to 1.10.1
4442359 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Jan 7, 2020
Closed
2 of 2 tasks complete
aduh95 added a commit to aduh95/node that referenced this pull request Jan 8, 2020
@Trott @aduh95
doc: update vm.md for link linting
ba2725c 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Jan 8, 2020
@Trott @aduh95
tools: update remark-preset-lint-node to 1.10.1
3877a77 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: nodejs#29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jan 8, 2020
@Trott @targos
doc: update vm.md for link linting
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
0d43135 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Jan 8, 2020
@Trott @targos
tools: update remark-preset-lint-node to 1.10.1
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
dbb4e2a 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
doc: update vm.md for link linting
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
30edcc0 
Update vm.md for link linting rules that are about to be applied. Define
an undefined link reference. Escape non-link text that uses `[` and `]`.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
tools: update remark-preset-lint-node to 1.10.1
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
b09eda5 
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks nschonni!).

Update other dependencies while at it.

PR-URL: #29982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@cjihrig cjihrig

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready fast-track tools
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Trott @targos @lpinca @cjihrig @richardlau @BridgeAR @nodejs-github-bot
You can’t perform that action at this time.