Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: remove unused Markdown reference links #29961
Conversation
This comment has been minimized.
This comment has been minimized.
|
Could split these 2 commits out to separate PRs, but was just probing to see what inline remark-lint disabled rules could be re-enabled using the latest master of the remark-node-preset |
| @@ -4631,8 +4631,6 @@ that points to its own memory allocated by a native module). Registering | |||
| externally allocated memory will trigger global garbage collections more | |||
| often than it would otherwise. | |||
|
|
|||
| <!-- it's very convenient to have all the anchors indexed --> | |||
This comment has been minimized.
This comment has been minimized.
nschonni
Oct 14, 2019
Author
Member
This is the only document that has it this way, and has been disabled for 2 years
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in 405a280...46648eb |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 16, 2019
PR-URL: nodejs#29961 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Trott
added a commit
that referenced
this pull request
Oct 16, 2019
MylesBorins
added a commit
that referenced
this pull request
Oct 23, 2019
PR-URL: #29961 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
added a commit
that referenced
this pull request
Oct 23, 2019
PR-URL: #29961 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
targos
added a commit
that referenced
this pull request
Nov 8, 2019
targos
added a commit
that referenced
this pull request
Nov 8, 2019
targos
added a commit
that referenced
this pull request
Nov 10, 2019
targos
added a commit
that referenced
this pull request
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nschonni commentedOct 14, 2019
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes