★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/29867Nouvelle recherche | Portail wanayoo
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm: unflag --experimental-exports #29867

Closed
wants to merge 1 commit into from
Closed

esm: unflag --experimental-exports #29867

wants to merge 1 commit into from

Conversation

@guybedford
Copy link
Contributor

guybedford commented Oct 7, 2019 •
edited

This removes the experimental --experimental-exports flag to make the support on by default.

This PR should not land until we have:

  • Resolution on package-relative loading PR (#29327)
  • Consensus to land from the modules group
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@guybedford guybedford mentioned this pull request Oct 7, 2019
Closed
14 of 14 tasks complete
@guybedford

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

guybedford commented Oct 7, 2019

//cc @nodejs/modules-active-members
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Oct 9, 2019

Added the WIP label based on the PR description (although feel free to swap it out for the blocked label if that's more appropriate).
@mhdawson mhdawson mentioned this pull request Oct 9, 2019
Closed
@guybedford guybedford force-pushed the guybedford:unflag-exports branch Oct 9, 2019
@guybedford

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

guybedford commented Oct 9, 2019

We got resolution in today's meeting to merge this, with the behaviour still flagged by --experimental-modules, thus making it part of the baseline modules features.

We just need core collaborator approvals to land further.
@jkrems
jkrems approved these changes Oct 9, 2019
View changes
Copy link
Contributor

jkrems left a comment

LGTM, as discussed in the WG meeting.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Oct 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25946/
@guybedford

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

guybedford commented Oct 10, 2019

Can I get a further review here from someone? Would be great to land soon to prepare for #29866.
@cjihrig
cjihrig approved these changes Oct 10, 2019
View changes
@Trott

This comment was marked as outdated.

Sign in to view
Copy link
Member

Trott commented Oct 10, 2019

Can I get a further review here from someone? Would be great to land soon to prepare for #29866.

@guybedford Once CI is green, I'll approve this one if no one else steps in to give it a proper review. It looks good to me, but there are people more qualified to review this stuff than I am and I would mildly prefer they take responsibility instead of me. 😆
@guybedford guybedford force-pushed the guybedford:unflag-exports branch Oct 10, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Oct 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25947/
@guybedford

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

guybedford commented Oct 10, 2019

Thanks @Trott just running a final CI with the latest rebase.
@Trott
Trott reviewed Oct 10, 2019
View changes
doc/api/cli.md Outdated Show resolved Hide resolved
@guybedford
esm: unflag --experimental-exports
Loading status checks…
8ff42aa
@guybedford guybedford force-pushed the guybedford:unflag-exports branch to 8ff42aa Oct 10, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Oct 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25948/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Oct 10, 2019

Landed in b798f64
@Trott Trott closed this Oct 10, 2019
Trott added a commit that referenced this pull request Oct 10, 2019
@guybedford @Trott
esm: unflag --experimental-exports
Loading status checks…
b798f64 
PR-URL: #29867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ljharb ljharb mentioned this pull request Oct 11, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2019
Merged
targos added a commit that referenced this pull request Nov 8, 2019
@guybedford @targos
esm: unflag --experimental-exports
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
808a302 
PR-URL: #29867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos added the semver-minor label Nov 10, 2019
targos added a commit that referenced this pull request Jan 8, 2020
@guybedford @targos
esm: unflag --experimental-exports
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
a0494cf 
PR-URL: #29867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@guybedford @BethGriggs
esm: unflag --experimental-exports
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
d6e69fb 
PR-URL: #29867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@joyeecheung joyeecheung mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@jkrems jkrems

@cjihrig cjihrig

Assignees
No one assigned
Labels
C++ ES Modules author ready semver-minor
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@guybedford @Trott @nodejs-github-bot @jkrems @cjihrig @targos
You can’t perform that action at this time.