★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/29585Nouvelle recherche | Portail wanayoo
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 35c6d4d #29585

Closed
wants to merge 2 commits into from
Closed

deps: V8: cherry-pick 35c6d4d #29585

wants to merge 2 commits into from

Conversation

@sam-github
Copy link
Member

sam-github commented Sep 16, 2019 •
edited

Original commit message:

Make code generator python3.7 compatible (async keyword).

Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29548
Refs:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@zaverden @devnexen
doc: update experimental loader hooks example code
Loading status checks…
1ecc406 
It fix 2 issues in provided Loader hooks examples:
1. Original ``new URL(`${process.cwd()}/`, 'file://');``
is not cross-platform, it gives wrong URL on windows
2. Based on `CHECK` in ModuleWrap::Resolve (node 12.9.1,
https://github.com/nodejs/node/blob/v12.9.1/src/module_wrap.cc#L1132)
the 2nd parameter should be a `string`, not an `URL` object

PR-URL: #29373
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@sam-github sam-github requested review from bnoordhuis, targos and cclauss Sep 16, 2019
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member Author

sam-github commented Sep 16, 2019

This just repeats previous changes, with enough metadata in the commit message someone might be able to trace the path the code took.

I think this fixes the last of #29326
@sam-github
deps: V8: cherry-pick 35c6d4d
Loading status checks…
a150d99 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29548
Refs:
- #29548 (comment)
- #29520
- #29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a
@sam-github sam-github force-pushed the sam-github:pick-code_generator.py-py3-compat branch to a150d99 Sep 16, 2019
@cclauss cclauss added the Python label Sep 16, 2019
@cclauss
cclauss approved these changes Sep 16, 2019
View changes
@cclauss
cclauss approved these changes Sep 16, 2019
View changes
Copy link
Contributor

cclauss left a comment

LGTM
@richardlau
richardlau approved these changes Sep 16, 2019
View changes
@cjihrig
cjihrig approved these changes Sep 17, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25515/
@bnoordhuis
bnoordhuis approved these changes Sep 17, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25516/
@Trott Trott force-pushed the nodejs:master branch from 1ecc406 to 49cf67e Sep 17, 2019
@sam-github sam-github mentioned this pull request Sep 17, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25517/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25532/
@BridgeAR
BridgeAR approved these changes Sep 18, 2019
View changes
cclauss added a commit that referenced this pull request Sep 18, 2019
@sam-github @cclauss
deps: V8: cherry-pick 35c6d4d
Loading status checks…
d36cef7 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29548
Refs:
- #29548 (comment)
- #29520
- #29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: #29585
Refs: #29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cclauss

This comment has been minimized.

Sign in to view
Copy link
Contributor

cclauss commented Sep 18, 2019

Landed in d36cef7
@cclauss cclauss closed this Sep 18, 2019
targos added a commit that referenced this pull request Sep 20, 2019
@sam-github @targos
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
7c88d60 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29548
Refs:
- #29548 (comment)
- #29520
- #29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: #29585
Refs: #29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR added a commit that referenced this pull request Sep 25, 2019
@sam-github @BridgeAR
deps: V8: cherry-pick 35c6d4d
Unverified
The committer email address is not verified.
Learn about signing commits
bc3c0b2 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29548
Refs:
- #29548 (comment)
- #29520
- #29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: #29585
Refs: #29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@beevelop beevelop mentioned this pull request Sep 25, 2019
Closed
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
cjihrig added a commit to cjihrig/node that referenced this pull request Sep 27, 2019
@sam-github @cjihrig
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
6ff076e 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: nodejs#29548
Refs:
- nodejs#29548 (comment)
- nodejs#29520
- nodejs#29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: nodejs#29585
Refs: nodejs#29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit to MylesBorins/node that referenced this pull request Oct 7, 2019
@sam-github @MylesBorins
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
e442e5a 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: nodejs#29548
Refs:
- nodejs#29548 (comment)
- nodejs#29520
- nodejs#29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: nodejs#29585
Refs: nodejs#29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit that referenced this pull request Oct 8, 2019
@sam-github @targos
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
8caf4e9 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29548
Refs:
- #29548 (comment)
- #29520
- #29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: #29585
Refs: #29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Oct 25, 2019
@sam-github @targos
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
a209381 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: nodejs#29548
Refs:
- nodejs#29548 (comment)
- nodejs#29520
- nodejs#29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: nodejs#29585
Refs: nodejs#29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@sam-github sam-github deleted the sam-github:pick-code_generator.py-py3-compat branch Nov 28, 2019
targos added a commit to targos/node that referenced this pull request Dec 5, 2019
@sam-github @targos
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
b10acaf 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: nodejs#29548
Refs:
- nodejs#29548 (comment)
- nodejs#29520
- nodejs#29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: nodejs#29585
Refs: nodejs#29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit to targos/node that referenced this pull request Jan 7, 2020
@sam-github @MylesBorins
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
4e6791b 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: nodejs#29548
Refs:
- nodejs#29548 (comment)
- nodejs#29520
- nodejs#29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

PR-URL: nodejs#29585
Refs: nodejs#29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request Jan 8, 2020
@sam-github @MylesBorins
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
43c5b91 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29548
Refs:
- #29548 (comment)
- #29520
- #29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

Backport-PR-URL: #30109
PR-URL: #29585
Refs: #29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@sam-github @BethGriggs
deps: V8: cherry-pick 35c6d4d
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
667b9a4 
Original commit message:

    Make code generator python3.7 compatible (async keyword).

    Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109

Fixes: #29548
Refs:
- #29548 (comment)
- #29520
- #29340
- https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
- https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a

Backport-PR-URL: #30109
PR-URL: #29585
Refs: #29520
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@cjihrig cjihrig

@cclauss cclauss

@richardlau richardlau

@BridgeAR BridgeAR

@targos targos

Assignees
No one assigned
Labels
Python V8 Engine
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

deps: need to cherrypick async fix into inspector code generator
8 participants
@sam-github @nodejs-github-bot @cclauss @bnoordhuis @cjihrig @richardlau @BridgeAR @zaverden
You can’t perform that action at this time.