★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/29456Nouvelle recherche | Portail wanayoo
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix OPENSSLDIR on Windows #29456

Closed
wants to merge 1 commit into from
Closed

deps: fix OPENSSLDIR on Windows #29456

wants to merge 1 commit into from

Conversation

@shigeki
Copy link
Contributor

shigeki commented Sep 5, 2019 •
edited

Backslashes and spaces are need to be escaped to define OPENSSLDIR to "C:\Program Files\Common Files\SSL".

Refs: #29455

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@shigeki
deps: fix OPENSSLDIR on Windows
Loading status checks…
f423e17 
Backslashes and spaces are need to be escaped to define OPENSSLDIR to
"C:\Program Files\Common Files\SSL".
@shigeki shigeki added the openssl label Sep 5, 2019
@shigeki

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

shigeki commented Sep 5, 2019

This fix was checked with the following output.

>Release\openssl-cli.exe version -a
OpenSSL 1.1.1c  28 May 2019
built on: Wed Jun 12 20:56:41 2019 UTC
platform:
options:  bn(64,64) rc4(16x,int) des(long) idea(int) blowfish(ptr)
compiler: cc
OPENSSLDIR: "C:\Program Files\Common Files\SSL"
ENGINESDIR: "NUL"
Seeding source: os-specific
@richardlau
richardlau approved these changes Sep 5, 2019
View changes
@sam-github
sam-github approved these changes Sep 5, 2019
View changes
Copy link
Member

sam-github left a comment

RSLGTM
@lpinca
lpinca approved these changes Sep 5, 2019
View changes
@cjihrig
cjihrig approved these changes Sep 6, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25403/
@mhdawson
mhdawson approved these changes Sep 10, 2019
View changes
Copy link
Member

mhdawson left a comment

LGTM
@jasnell
jasnell approved these changes Sep 11, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 11, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25429/
@Trott Trott force-pushed the nodejs:master branch from 1ecc406 to 49cf67e Sep 17, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Nov 30, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27229/
@Trott
Trott approved these changes Dec 6, 2019
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 6, 2019

Landed in eea5bb4
@Trott Trott closed this Dec 6, 2019
Trott added a commit to Trott/io.js that referenced this pull request Dec 6, 2019
@shigeki @Trott
deps: fix OPENSSLDIR on Windows
eea5bb4 
Backslashes and spaces are need to be escaped to define OPENSSLDIR to
"C:\Program Files\Common Files\SSL".

PR-URL: nodejs#29456
Refs: nodejs#29455
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Dec 9, 2019
@shigeki @targos
deps: fix OPENSSLDIR on Windows
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
4588606 
Backslashes and spaces are need to be escaped to define OPENSSLDIR to
"C:\Program Files\Common Files\SSL".

PR-URL: #29456
Refs: #29455
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos added a commit that referenced this pull request Jan 13, 2020
@shigeki @targos
deps: fix OPENSSLDIR on Windows
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
b27b420 
Backslashes and spaces are need to be escaped to define OPENSSLDIR to
"C:\Program Files\Common Files\SSL".

PR-URL: #29456
Refs: #29455
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs added a commit that referenced this pull request Feb 6, 2020
@shigeki @BethGriggs
deps: fix OPENSSLDIR on Windows
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
ff82ccb 
Backslashes and spaces are need to be escaped to define OPENSSLDIR to
"C:\Program Files\Common Files\SSL".

PR-URL: #29456
Refs: #29455
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
saitonakamura pushed a commit to saitonakamura/node that referenced this pull request Apr 7, 2020
@shigeki Michael Bashurov
deps: fix OPENSSLDIR on Windows
b400a54 
Backslashes and spaces are need to be escaped to define OPENSSLDIR to
"C:\Program Files\Common Files\SSL".

PR-URL: nodejs#29456
Refs: nodejs#29455
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github

@jasnell jasnell

@Trott Trott

@lpinca lpinca

@cjihrig cjihrig

@richardlau richardlau

@mhdawson mhdawson

Assignees
No one assigned
Labels
author ready build openssl
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
@shigeki @nodejs-github-bot @Trott @sam-github @jasnell @lpinca @cjihrig @richardlau @mhdawson @addaleax
You can’t perform that action at this time.