★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/29098Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default #29098

Closed
wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

commented Aug 12, 2019

This commit changes the default message used by ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default message implied that the problematic was always a write, which is not accurate.

Fixes: #29097

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@cjihrig
buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default 
This commit changes the default message used by
ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default
message implied that the problematic was always a
write, which is not accurate.
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
cec1242

@nodejs-github-bot nodejs-github-bot added the errors label Aug 12, 2019

@addaleax
addaleax approved these changes Aug 12, 2019
View changes
@sam-github
sam-github approved these changes Aug 12, 2019
View changes
@gengjiawen
gengjiawen approved these changes Aug 13, 2019
View changes
@jasnell
jasnell approved these changes Aug 13, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 13, 2019 •
edited by cjihrig

CI: https://ci.nodejs.org/job/node-test-pull-request/24962/

EDIT: CI was yellow.
@lpinca
lpinca approved these changes Aug 13, 2019
View changes
@ZYSzys
ZYSzys approved these changes Aug 13, 2019
View changes

@ZYSzys ZYSzys added the author ready label Aug 13, 2019

@patilharshal16
patilharshal16 reviewed Aug 14, 2019
View changes
Copy link

left a comment

Looks ok. Just change in return message
@patilharshal16
patilharshal16 approved these changes Aug 14, 2019
View changes
@Trott
Trott approved these changes Aug 14, 2019
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 14, 2019

Landed in a352a71

@Trott Trott closed this Aug 14, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 14, 2019
@cjihrig @Trott
buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default 
This commit changes the default message used by
ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default
message implied that the problematic was always a
write, which is not accurate.

PR-URL: nodejs#29098
Fixes: nodejs#29097
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
a352a71

@cjihrig cjihrig deleted the cjihrig:oob-err branch Aug 15, 2019

targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default 
This commit changes the default message used by
ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default
message implied that the problematic was always a
write, which is not accurate.

PR-URL: #29098
Fixes: #29097
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e494c40
targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default 
This commit changes the default message used by
ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default
message implied that the problematic was always a
write, which is not accurate.

PR-URL: #29098
Fixes: #29097
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c7a4525
@targos targos referenced this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default 
This commit changes the default message used by
ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default
message implied that the problematic was always a
write, which is not accurate.

PR-URL: nodejs#29098
Fixes: nodejs#29097
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
06145e9
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default 
This commit changes the default message used by
ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default
message implied that the problematic was always a
write, which is not accurate.

PR-URL: nodejs#29098
Fixes: nodejs#29097
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
ae976dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github

@jasnell jasnell

@Trott Trott

@addaleax addaleax

@lpinca lpinca

@gengjiawen gengjiawen

@patilharshal16 patilharshal16

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready errors
Projects
None yet
Milestone
No milestone
10 participants
@cjihrig @nodejs-github-bot @Trott @sam-github @jasnell @addaleax @lpinca @gengjiawen @patilharshal16 @ZYSzys
You can’t perform that action at this time.