★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/29054Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unskip tests that now pass on AIX #29054

Closed
wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Member

commented Aug 8, 2019 •
edited

One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and it's parent processes.

See: nodejs/build#1849 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Aug 8, 2019

@sam-github sam-github force-pushed the sam-github:unskip-aix branch from b451176 to 260d3bc Aug 8, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24894/
@cjihrig
cjihrig approved these changes Aug 8, 2019
View changes
@lpinca
lpinca approved these changes Aug 8, 2019
View changes
@Trott
Trott approved these changes Aug 8, 2019
View changes
@richardlau
richardlau approved these changes Aug 9, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24898/
@sam-github
test: unskip tests that now pass on AIX 
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)
Loading status checks…
79548b9

@sam-github sam-github force-pushed the sam-github:unskip-aix branch from 260d3bc to 79548b9 Aug 9, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24905/
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Aug 9, 2019

2 CIs in a row were green. kicked off a last, but this is looking good.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 11, 2019

Landed in c146f88

@Trott Trott closed this Aug 11, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 11, 2019
@sam-github @Trott
test: unskip tests that now pass on AIX 
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: nodejs#29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
c146f88
targos added a commit that referenced this pull request Aug 19, 2019
@sam-github @targos
test: unskip tests that now pass on AIX 
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: #29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c4b93cf
targos added a commit that referenced this pull request Aug 19, 2019
@sam-github @targos
test: unskip tests that now pass on AIX 
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: #29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e3b1243
@targos targos referenced this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@sam-github @JeniaBR
test: unskip tests that now pass on AIX 
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: nodejs#29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
e481e13
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@sam-github @JeniaBR
test: unskip tests that now pass on AIX 
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: nodejs#29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
8df7228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@lpinca lpinca

@cjihrig cjihrig

@richardlau richardlau

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
6 participants
@sam-github @nodejs-github-bot @Trott @lpinca @cjihrig @richardlau
You can’t perform that action at this time.