★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/29040Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: update lookupService() first arg name #29040

Closed
wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

commented Aug 8, 2019

The first argument to lookupService() should be an IP address, and is named "address" in the documentation. This commit updates the code to match the documentation and provide less confusing errors.

Fixes: #29039

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the dns label Aug 8, 2019

@Trott
Trott approved these changes Aug 8, 2019
View changes
Copy link
Member

left a comment

The code variable names should always match the docs because they are exposed in stack traces. I wish there were a trivial way to lint for this in the docs.
@sam-github
sam-github approved these changes Aug 8, 2019
View changes
test/parallel/test-dns.js Outdated Show resolved Hide resolved
@cjihrig
dns: update lookupService() first arg name 
The first argument to lookupService() should be an IP address,
and is named "address" in the documentation. This commit updates
the code to match the documentation and provide less confusing
errors.
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
9a41646

@cjihrig cjihrig force-pushed the cjihrig:dns-err branch from 134f97b to 9a41646 Aug 8, 2019

@trivikr
trivikr approved these changes Aug 8, 2019
View changes
@targos
targos approved these changes Aug 8, 2019
View changes
@jasnell
jasnell approved these changes Aug 8, 2019
View changes
@lpinca
lpinca approved these changes Aug 8, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24928/
Trott added a commit to Trott/io.js that referenced this pull request Aug 11, 2019
@cjihrig @Trott
dns: update lookupService() first arg name 
The first argument to lookupService() should be an IP address,
and is named "address" in the documentation. This commit updates
the code to match the documentation and provide less confusing
errors.

PR-URL: nodejs#29040
Fixes: nodejs#29039
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
df936c5
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 11, 2019

Landed in df936c5

@Trott Trott closed this Aug 11, 2019

@cjihrig cjihrig deleted the cjihrig:dns-err branch Aug 11, 2019

targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
dns: update lookupService() first arg name 
The first argument to lookupService() should be an IP address,
and is named "address" in the documentation. This commit updates
the code to match the documentation and provide less confusing
errors.

PR-URL: #29040
Fixes: #29039
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
dad1aa9
targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
dns: update lookupService() first arg name 
The first argument to lookupService() should be an IP address,
and is named "address" in the documentation. This commit updates
the code to match the documentation and provide less confusing
errors.

PR-URL: #29040
Fixes: #29039
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6f7b561
@targos targos referenced this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
dns: update lookupService() first arg name 
The first argument to lookupService() should be an IP address,
and is named "address" in the documentation. This commit updates
the code to match the documentation and provide less confusing
errors.

PR-URL: nodejs#29040
Fixes: nodejs#29039
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
4079fff
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
dns: update lookupService() first arg name 
The first argument to lookupService() should be an IP address,
and is named "address" in the documentation. This commit updates
the code to match the documentation and provide less confusing
errors.

PR-URL: nodejs#29040
Fixes: nodejs#29039
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
513abf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github

@jasnell jasnell

@Trott Trott

@lpinca lpinca

@targos targos

@trivikr trivikr

Assignees
No one assigned
Labels
dns
Projects
None yet
Milestone
No milestone
8 participants
@cjihrig @nodejs-github-bot @Trott @sam-github @jasnell @lpinca @targos @trivikr
You can’t perform that action at this time.