Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesconf: linux large pages LLVM lld linkage support #28938
+22
−1
Conversation
nodejs-github-bot
added
build
C++
labels
Aug 2, 2019
devnexen
force-pushed the
devnexen:large_pages_ld_support
branch
from
cc4cc3c
to
d0c3498
Aug 2, 2019
bnoordhuis
approved these changes
Aug 6, 2019
|
Thanks, LGTM but can you keep lines <= 80 columns? In the .gypi you can write it like this: ['OS=="linux" and '
'target_arch=="x64" and '
'node_use_large_pages=="true" and '
'node_use_large_pages_script_lld=="false"', {
# ...
} |
This comment has been minimized.
This comment has been minimized.
|
@devnexen Are you a collaborator yet? If not, I'd be happy to nominate you. |
devnexen
force-pushed the
devnexen:large_pages_ld_support
branch
from
d0c3498
to
46e39f8
Aug 6, 2019
This comment has been minimized.
This comment has been minimized.
|
Not yet indeed :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in 0d7acfa |
Trott
closed this
Aug 20, 2019
Trott
added a commit
that referenced
this pull request
Aug 20, 2019
targos
added a commit
that referenced
this pull request
Aug 20, 2019
This was referenced Aug 20, 2019
JeniaBR
added a commit
to JeniaBR/node
that referenced
this pull request
Sep 11, 2019
JeniaBR
added a commit
to JeniaBR/node
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
devnexen commentedAug 2, 2019
•
edited
The custom linker script is compatible with GNU ld only.
As such, providin a new expliciting option to redirect to
a different one. lld seems unable to migrate this
large section w/o segfaulting so providing only the
base address anchor for now.