★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28458

Nouvelle recherche | Portail wanayoo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centos7 ppc64 le v8 test support #28458

Closed

sam-github wants to merge 2 commits into nodejs:master from sam-github:centos7-ppc64-le-v8-test-support

Contributor

sam-github commented Jun 27, 2019 •

edited

one:

tools: move python code out of jenkins shell

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

two:

tools: fix v8 testing with devtoolset on ppcle

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

The text was updated successfully, but these errors were encountered:

nodejs-github-bot added build tools v8 engine labels

sam-github mentioned this pull request

update node-test-commit-v8-linux to not overwrite make-v8.sh with a local copy nodejs/build#1857

Closed

sam-github added 2 commits


          tools: fix v8 testing with devtoolset on ppcle

28974ee

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.


          tools: move python code out of jenkins shell

c3db2ca

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

sam-github force-pushed the centos7-ppc64-le-v8-test-support branch from 1166b09 to c3db2ca

sam-github marked this pull request as ready for review

Contributor Author

sam-github commented Jun 28, 2019 •

edited

centos7-ppcle passed in: https://ci.nodejs.org/job/node-test-commit-v8-linux/2396/nodes=centos7-ppcle,v8test=v8test/console

repeat the builds:

lite ci: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3726/ PASS

v8 ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/2399/ PASS

Member

richardlau commented Jun 28, 2019

Are the three new Python scripts meant to be called from an existing Python/shell script?

Contributor Author

sam-github commented Jun 28, 2019

@richardlau Sorry, pulled the commit message details into the description. I wish github did that for me on multi-commit PRs.

richardlau approved these changes

mhdawson approved these changes

Member

mhdawson left a comment

LGTM

Contributor Author

sam-github commented Jun 28, 2019

Can I fast-track this, @nodejs/build @targos ?

Member

mhdawson commented Jun 28, 2019

+1 to fast track from me

mhdawson added the fast-track label

Trott approved these changes

Member

danbev commented Jul 2, 2019

Landed in e669b81, and ed14aa6.

danbev closed this

danbev added a commit that referenced this issue


          tools: fix v8 testing with devtoolset on ppcle

e669b81

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

danbev added a commit that referenced this issue


          tools: move python code out of jenkins shell

ed14aa6

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added a commit that referenced this issue


          tools: fix v8 testing with devtoolset on ppcle

47046cf

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added a commit that referenced this issue


          tools: move python code out of jenkins shell

c41c6ce

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added a commit that referenced this issue


          tools: fix v8 testing with devtoolset on ppcle

d38b985

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added a commit that referenced this issue


          tools: move python code out of jenkins shell

40ae2a6

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos mentioned this pull request

Release v12.6.0 proposal #28508

Merged

beevelop mentioned this pull request

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#288

Closed

beevelop mentioned this pull request

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#289

Closed

beevelop mentioned this pull request

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#290

Closed

cclauss added the python label

sam-github deleted the centos7-ppc64-le-v8-test-support branch

richardlau mentioned this pull request

[v10.x] deps: V8: backport fb63e5cf55e9 #30372

Closed

BethGriggs added the lts-watch-v10.x label

BethGriggs pushed a commit that referenced this issue


          tools: fix v8 testing with devtoolset on ppcle

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this issue


          tools: move python code out of jenkins shell

7ff19be

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs removed the lts-watch-v10.x label

BethGriggs mentioned this pull request

v10.18.1 proposal #30796

Closed

MylesBorins added a commit that referenced this issue


          tools: fix v8 testing with devtoolset on ppcle

4879b80

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this issue


          tools: move python code out of jenkins shell

4ae8d20

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs mentioned this pull request

v10.18.1 proposal #31248

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment