Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesdoc: cleanup pendingSettingsAck docs #28388
Conversation
nodejs-github-bot
added
doc
http2
labels
Jun 22, 2019
lpinca
approved these changes
Jun 22, 2019
trivikr
approved these changes
Jun 23, 2019
jasnell
approved these changes
Jun 23, 2019
This comment has been minimized.
This comment has been minimized.
Trott
reviewed
Jun 24, 2019
doc/api/http2.md
Outdated
| Indicates whether or not the `Http2Session` is currently waiting for an | ||
| acknowledgment for a sent `SETTINGS` frame. Will be `true` after calling the | ||
| `http2session.settings()` method. Will be `false` once all sent SETTINGS | ||
| Indicates whether or not the `Http2Session` is currently waiting for |
This comment has been minimized.
This comment has been minimized.
Trott
Jun 24, 2019
Member
Totally optional micro-suggestion:
Suggested change
| Indicates whether or not the `Http2Session` is currently waiting for | |
| Indicates whether the `Http2Session` is currently waiting for |
Trott
approved these changes
Jun 24, 2019
cjihrig
force-pushed the
cjihrig:pending
branch
from
06ba5d9
to
a7e0155
Jun 25, 2019
cjihrig
merged commit a7e0155
into
nodejs:master
Jun 25, 2019
cjihrig
deleted the
cjihrig:pending
branch
Jun 25, 2019
jshricarde
added a commit
to jshricarde/node
that referenced
this pull request
Jun 25, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cjihrig commentedJun 22, 2019
This commit rephrases the first sentence of the http2 session
pendingSettingsAckproperty docs. It also formatsSETTINGSconsistently.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes