★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28385Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix nits regarding stream utilities #28385

Closed
wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Jun 22, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Unify headings.
  • Conform method mentions with the style guide.
  • Fix links.

### Readable.from() -> ### stream.Readable.from() heading change seems suboptimal and non-typical, but it seems it would be wrong to place this part with descriptions of Readable instances or to leave it as is along with other stream.* utilities, in incorrect structure and sorting place.

@nodejs-github-bot nodejs-github-bot added doc stream labels Jun 22, 2019

@vsemozhetbyt
doc: fix nits regarding stream utilities 
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.
Loading status checks…
478b2f7

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-stream-util-nits branch from 6a34037 to 478b2f7 Jun 22, 2019

@Trott
Trott approved these changes Jun 22, 2019
View changes
@cjihrig
cjihrig approved these changes Jun 22, 2019
View changes
@ZYSzys
ZYSzys approved these changes Jun 22, 2019
View changes
@BridgeAR
BridgeAR approved these changes Jun 22, 2019
View changes
@lpinca
lpinca approved these changes Jun 22, 2019
View changes
@trivikr
trivikr approved these changes Jun 23, 2019
View changes
@jasnell
jasnell approved these changes Jun 23, 2019
View changes

@Trott Trott added the author ready label Jun 24, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 24, 2019

LIte CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3709/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 25, 2019

Landed in daa512b

@addaleax addaleax closed this Jun 25, 2019

addaleax added a commit that referenced this pull request Jun 25, 2019
@vsemozhetbyt @addaleax
doc: fix nits regarding stream utilities 
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

PR-URL: #28385
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
daa512b

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-stream-util-nits branch Jun 25, 2019

jshricarde added a commit to jshricarde/node that referenced this pull request Jun 25, 2019
@vsemozhetbyt @jshricarde
doc: fix nits regarding stream utilities 
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

PR-URL: nodejs#28385
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
67370ac
targos added a commit that referenced this pull request Jul 2, 2019
@vsemozhetbyt @targos
doc: fix nits regarding stream utilities 
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

PR-URL: #28385
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e3dd4d5
@targos targos referenced this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@lpinca lpinca

@cjihrig cjihrig

@BridgeAR BridgeAR

@trivikr trivikr

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready doc stream
Projects
None yet
Milestone
No milestone
10 participants
@vsemozhetbyt @Trott @addaleax @jasnell @lpinca @cjihrig @BridgeAR @trivikr @ZYSzys @nodejs-github-bot
You can’t perform that action at this time.