★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28359Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix order of assertion arguments in test-buffer-indexof #28359

Closed
wants to merge 3 commits into from

Conversation

@MistyBlunch
Copy link
Contributor

commented Jun 21, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@MistyBlunch
test: change order of arguments
Loading status checks…
55e142e

@nodejs-github-bot nodejs-github-bot added the tools label Jun 21, 2019

@Trott
Trott requested changes Jun 21, 2019
View changes
Copy link
Member

left a comment

Welcome @MistyBlunch and thanks for the pull request! There appears to be an unrelated change in this pull request that should be removed. Additionally, the commit message can be improved. Perhaps this?: test: fix order of assertion arguments in test-buffer-indexof Hope this help!
tools/macos-firewall.sh Outdated Show resolved Hide resolved

@MistyBlunch MistyBlunch changed the title test: change order of arguments test: fix order of assertion arguments in test-buffer-indexof Jun 21, 2019

MistyBlunch added 2 commits Jun 21, 2019
@MistyBlunch
change the macos-firewall.sh
Loading status checks…
194fda1
@MistyBlunch
fix all
Loading status checks…
e87cfa3
@Trott
Trott approved these changes Jun 22, 2019
View changes
@addaleax
addaleax approved these changes Jun 22, 2019
View changes

@addaleax addaleax added the author ready label Jun 22, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 22, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24062/
@cjihrig
cjihrig approved these changes Jun 22, 2019
View changes
@BridgeAR
BridgeAR approved these changes Jun 22, 2019
View changes
@jasnell
jasnell approved these changes Jun 23, 2019
View changes

@jasnell jasnell added the code-and-learn label Jun 23, 2019

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 25, 2019

Landed in 6966e15

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Jun 25, 2019

pull bot pushed a commit to Pandinosaurus/node that referenced this pull request Jun 25, 2019
@MistyBlunch @addaleax
test: change order of arguments 
PR-URL: nodejs#28359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
6966e15
jshricarde added a commit to jshricarde/node that referenced this pull request Jun 25, 2019
@MistyBlunch @jshricarde
test: change order of arguments 
PR-URL: nodejs#28359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
821cb2c
targos added a commit that referenced this pull request Jul 2, 2019
@MistyBlunch @targos
test: change order of arguments 
PR-URL: #28359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
4bca4a5
@targos targos referenced this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@addaleax addaleax

@cjihrig cjihrig

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready code-and-learn tools
Projects
None yet
Milestone
No milestone
7 participants
@MistyBlunch @nodejs-github-bot @addaleax @jasnell @Trott @cjihrig @BridgeAR
You can’t perform that action at this time.