★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28307Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-worker-debug #28307

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Jun 19, 2019

Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: #28299
Fixes: #28106

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax
test: fix flaky test-worker-debug 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: #28299
Fixes: #28106
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
441fc92

@nodejs-github-bot nodejs-github-bot added the test label Jun 19, 2019

@addaleax addaleax added CI / flaky test fast-track worker inspector labels Jun 19, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23986/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 19, 2019 •
edited

Stress test: https://ci.nodejs.org/job/node-stress-single-test/2232/
Stress test: https://ci.nodejs.org/job/node-stress-single-test/2233/

Please 👍 this comment to approve fast-tracking.
@richardlau
richardlau approved these changes Jun 19, 2019
View changes
@addaleax addaleax referenced this pull request Jun 19, 2019
Closed
0 of 4 tasks complete

@addaleax addaleax added the author ready label Jun 19, 2019

@cjihrig
cjihrig approved these changes Jun 20, 2019
View changes
@ZYSzys
ZYSzys approved these changes Jun 20, 2019
View changes
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 20, 2019

Landed in 2dec0f9.

@danbev danbev closed this Jun 20, 2019

danbev added a commit that referenced this pull request Jun 20, 2019
@addaleax @danbev
test: fix flaky test-worker-debug 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Loading status checks…
2dec0f9

@addaleax addaleax deleted the addaleax:test-worker-debug-fix branch Jun 20, 2019

targos added a commit that referenced this pull request Jul 2, 2019
@addaleax @targos
test: fix flaky test-worker-debug 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c44db7f
@targos targos referenced this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig

@richardlau richardlau

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
CI / flaky test author ready fast-track inspector test worker
Projects
None yet
Milestone
No milestone
6 participants
@addaleax @nodejs-github-bot @danbev @cjihrig @richardlau @ZYSzys
You can’t perform that action at this time.