★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28266Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update babel-eslint to 10.0.2 #28266

Closed
wants to merge 1 commit into from
+567 −10

Conversation

@ZYSzys
Copy link
Member

commented Jun 17, 2019 •
edited

Update babel-eslint to 10.0.2 by running tools/update-babel-eslint.sh.

Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@ZYSzys
tools: update babel-eslint to 10.0.2
Loading status checks…
ea543b7

@nodejs-github-bot nodejs-github-bot added the tools label Jun 17, 2019

@ZYSzys

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 17, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3688/
@BridgeAR
BridgeAR approved these changes Jun 17, 2019
View changes
Copy link
Member

left a comment

RSLGTM

This seems to add a few files that were missing before 👍 (even though it seems like we did not require them).

@BridgeAR BridgeAR added the author ready label Jun 17, 2019

@trivikr
trivikr approved these changes Jun 17, 2019
View changes
Copy link
Member

left a comment

RSLGTM
@fhinkel
fhinkel approved these changes Jun 19, 2019
View changes
@Trott
Trott approved these changes Jun 19, 2019
View changes
Copy link
Member

left a comment

Rubber-stamp LGTM
@Trott
Trott approved these changes Jun 19, 2019
View changes
Copy link
Member

left a comment

Non-rubber-stamp LGTM. The change set is manageable so I was able to actually review it. :-D
@cjihrig
cjihrig approved these changes Jun 19, 2019
View changes
@ZYSzys

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 20, 2019

Landed in d698983.

@ZYSzys ZYSzys closed this Jun 20, 2019

ZYSzys added a commit to zys-contribs/node that referenced this pull request Jun 20, 2019
@ZYSzys
tools: update babel-eslint to 10.0.2 
PR-URL: nodejs#28266
Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Loading status checks…
d698983

@ZYSzys ZYSzys deleted the zys-contribs:babel-eslint branch Jun 20, 2019

targos added a commit that referenced this pull request Jul 2, 2019
@ZYSzys @targos
tools: update babel-eslint to 10.0.2 
PR-URL: #28266
Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
dd53e6a
@targos targos referenced this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel

@Trott Trott

@cjihrig cjihrig

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
author ready tools
Projects
None yet
Milestone
No milestone
7 participants
@ZYSzys @fhinkel @Trott @cjihrig @BridgeAR @trivikr @nodejs-github-bot
You can’t perform that action at this time.