★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28259Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Worker + uncaughtException + process.exit() test #28259

Closed
wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

commented Jun 17, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax
test: add Worker + uncaughtException + process.exit() test
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
6401e56

@addaleax addaleax added test worker labels Jun 17, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 17, 2019

Sadly, an error occurred when I tried to trigger a build. :(
@addaleax addaleax referenced this pull request Jun 17, 2019
Closed
2 of 2 tasks complete
@gireeshpunathil
gireeshpunathil approved these changes Jun 17, 2019
View changes
@Trott
Trott requested changes Jun 17, 2019
View changes
Copy link
Member

left a comment

This test will fail if run with the tools/test.py --worker.
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 17, 2019 •
edited

Maybe put the worker code in a fixture instead? So it won't get run by --worker. Or just eval the code.
@addaleax
fixup! test: add Worker + uncaughtException + process.exit() test
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
7e17d7e
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 17, 2019

@joyeecheung @Trott I’ve updated this with the standard approach we use in our tests (using an env var instead of isMainThread)
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23937/
@joyeecheung
joyeecheung approved these changes Jun 17, 2019
View changes
@Trott
Trott approved these changes Jun 17, 2019
View changes
@fhinkel
fhinkel approved these changes Jun 19, 2019
View changes
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 19, 2019

Landed in 7146ddd

@addaleax addaleax closed this Jun 19, 2019

@addaleax addaleax deleted the addaleax:worker-uncaught-exception branch Jun 19, 2019

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Jun 19, 2019
@addaleax
test: add Worker + uncaughtException + process.exit() test 
PR-URL: nodejs#28259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
7146ddd
targos added a commit that referenced this pull request Jul 2, 2019
@addaleax @targos
test: add Worker + uncaughtException + process.exit() test 
PR-URL: #28259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
72f52a3
@targos targos referenced this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel

@Trott Trott

@joyeecheung joyeecheung

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
test worker
Projects
None yet
Milestone
No milestone
6 participants
@addaleax @nodejs-github-bot @joyeecheung @fhinkel @Trott @gireeshpunathil
You can’t perform that action at this time.