lib: refactor unhandled rejection deprecation warning emission
Emit the deprecation warning in the `kDefaultUnhandledRejections` case to reduce the number of branches on unhandled rejection mode - there is now only one switch case on it. Also rename `emitWarning()` to `emitUnhandledRejectionWarning()` to avoid ambiguity with `process.emitWarning()`

fixup! lib: refactor unhandled rejection deprecation warning emission
lib: refactor unhandled rejection deprecation warning emission
Emit the deprecation warning in the `kDefaultUnhandledRejections` case to reduce the number of branches on unhandled rejection mode - there is now only one switch case on it. Also rename `emitWarning()` to `emitUnhandledRejectionWarning()` to avoid ambiguity with `process.emitWarning()` PR-URL: #28258 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
nodejs · joyeecheung · joyeecheung · joyeecheung · Jun 17, 2019 · nodejs-github-bot
diff --git a/lib/internal/process/promises.js b/lib/internal/process/promises.js
 }

 let deprecationWarned = false;
 function emitDeprecationWarning() {
-  if (unhandledRejectionsMode === kDefaultUnhandledRejections &&
diff --git a/lib/internal/process/promises.js b/lib/internal/process/promises.js
+        if (!deprecationWarned) {
+          emitDeprecationWarning();
+          deprecationWarned = true;
+        }