★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28224Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: document the Date conversion in Stats objects #28224

Closed
wants to merge 2 commits into from
+6 −0

Conversation

@joyeecheung
Copy link
Member

commented Jun 14, 2019

Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: ae6c704

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@joyeecheung
fs: document the Date conversion in Stats objects 
Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: ae6c704
Verified
This commit was signed with a verified signature.
joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
61699e6
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 14, 2019 •
edited

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23877/

@nodejs-github-bot nodejs-github-bot added the fs label Jun 14, 2019

@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 16, 2019

cc @nodejs/fs
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23905/
@joyeecheung joyeecheung referenced this pull request Jun 16, 2019
Open
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 17, 2019

cc'ing people who reverted the original commit @addaleax @TimothyGu @refack @cjihrig
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23919/
@addaleax
addaleax approved these changes Jun 17, 2019
View changes
@jasnell
jasnell approved these changes Jun 17, 2019
View changes

@addaleax addaleax added the author ready label Jun 17, 2019

@Trott
Trott reviewed Jun 17, 2019
View changes
lib/internal/fs/utils.js Outdated Show resolved Hide resolved
@Trott
Trott approved these changes Jun 17, 2019
View changes
Copy link
Member

left a comment

LGTM with or without small typo in comment fixed.
@joyeecheung
fixup! fs: document the Date conversion in Stats objects
Verified
This commit was signed with a verified signature.
joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
9521cd9
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23925/
@BridgeAR
BridgeAR approved these changes Jun 17, 2019
View changes
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jun 17, 2019
@joyeecheung @BridgeAR
fs: document the Date conversion in Stats objects 
Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: nodejs@ae6c704

PR-URL: nodejs#28224
Refs: nodejs@ae6c704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
b6326ce
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 17, 2019

Landed in b6326ce 🎉

@BridgeAR BridgeAR closed this Jun 17, 2019

BridgeAR added a commit that referenced this pull request Jun 17, 2019
@joyeecheung @BridgeAR
fs: document the Date conversion in Stats objects 
Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: ae6c704

PR-URL: #28224
Refs: ae6c704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
e89a39b
@BridgeAR BridgeAR referenced this pull request Jun 17, 2019
Merged

@targos targos added the backport-blocked-v12.x label Jul 2, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
@joyeecheung @BridgeAR
fs: document the Date conversion in Stats objects 
Document why the dates are calculated with the timestamp
in Numbers + 0.5.

The comment was previously lost in a revert.

Refs: ae6c704

PR-URL: #28224
Refs: ae6c704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
e6353bd
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
Merged

@BridgeAR BridgeAR added backported-to-v12.x and removed backport-blocked-v12.x labels Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@addaleax addaleax

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready backported-to-v12.x fs
Projects
None yet
Milestone
No milestone
7 participants
@joyeecheung @nodejs-github-bot @BridgeAR @jasnell @Trott @addaleax @targos
You can’t perform that action at this time.