★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28206Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: hide NodeEnvironmentFlagsSet's `add` function #28206

Closed
wants to merge 1 commit into from
+3 −1

Conversation

@BridgeAR
Copy link
Member

commented Jun 13, 2019

This makes sure that the add function is not visible by default
when inspecting process.allowedNodeEnvironmentFlags.

image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@BridgeAR
process: hide NodeEnvironmentFlagsSet's `add` function 
This makes sure that the `add` function is not visible by default
when inspecting `process.allowedNodeEnvironmentFlags`.
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
d87b647

@BridgeAR BridgeAR added the process label Jun 13, 2019

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
Copy link

commented Jun 13, 2019 •
edited

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23902/
@richardlau
richardlau approved these changes Jun 13, 2019
View changes
@addaleax
addaleax approved these changes Jun 13, 2019
View changes
@jasnell
jasnell approved these changes Jun 14, 2019
View changes

@BridgeAR BridgeAR added the author ready label Jun 15, 2019

@joyeecheung joyeecheung referenced this pull request Jun 16, 2019
Open
@Trott
Trott approved these changes Jun 17, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23917/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23929/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23941/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 17, 2019

Landed in 14be3aa

@Trott Trott closed this Jun 17, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jun 17, 2019
@BridgeAR @Trott
process: hide NodeEnvironmentFlagsSet's `add` function 
This makes sure that the `add` function is not visible by default
when inspecting `process.allowedNodeEnvironmentFlags`.

PR-URL: nodejs#28206
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
14be3aa
targos added a commit that referenced this pull request Jul 2, 2019
@BridgeAR @targos
process: hide NodeEnvironmentFlagsSet's `add` function 
This makes sure that the `add` function is not visible by default
when inspecting `process.allowedNodeEnvironmentFlags`.

PR-URL: #28206
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e517b03
@targos targos referenced this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@addaleax addaleax

@richardlau richardlau

Assignees
No one assigned
Labels
author ready process
Projects
None yet
Milestone
No milestone
6 participants
@BridgeAR @nodejs-github-bot @Trott @jasnell @addaleax @richardlau
You can’t perform that action at this time.