test: remove test-gc-http-client from status file #28130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly, an error occurred when I tried to trigger a build. :( |
gireeshpunathil
approved these changes
Jun 8, 2019
sam-github
approved these changes
Jun 8, 2019
antsmartian
approved these changes
Jun 8, 2019
lpinca
approved these changes
Jun 8, 2019
cjihrig
approved these changes
Jun 8, 2019
BridgeAR
approved these changes
Jun 8, 2019
trivikr
approved these changes
Jun 9, 2019
jasnell
approved these changes
Jun 10, 2019
test-gc-http-client is no longer believed to be unreliable. Remove it's entry indicating it's flaky from the status file. Closes: nodejs#22336 PR-URL: nodejs#28130 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 64d7056 |
BridgeAR
added a commit
that referenced
this issue
Jun 17, 2019
test-gc-http-client is no longer believed to be unreliable. Remove it's entry indicating it's flaky from the status file. Closes: #22336 PR-URL: #28130 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
test-gc-http-client is no longer believed to be unreliable. Remove it's
entry indicating it's flaky from the status file.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes