doc: fix prohibited-strings warning in pull-requests.md
#28127
Conversation
|
Anyone know why that file isn't getting linted with |
The Line 1162 in 6447be6 bash, for example, the globstar option would need to be set: https://unix.stackexchange.com/questions/62660/the-result-of-ls-ls-and-ls/62665#62665
|
|
#28128 should fix the |
Correct "Github" to "GitHub" in compliance to the linting standards. PR-URL: nodejs#28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 03d008f |
|
Thanks for the contribution! (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
`**` expansion doesn't behave as expected and as a result files in nested subdirectories under `doc` were not linted. Use `find` instead to generate the list of files to lint. PR-URL: nodejs#28128 Refs: nodejs#28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Correct "Github" to "GitHub" in compliance to the linting standards. PR-URL: #28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
`**` expansion doesn't behave as expected and as a result files in nested subdirectories under `doc` were not linted. Use `find` instead to generate the list of files to lint. PR-URL: #28128 Refs: #28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
corrected "Github" to "GitHub" in compliance
to the linting standards
Checklist
Warn log