★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/28125Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: resolve ambiguity in pull-requests.md #28125

Closed
wants to merge 1 commit into from
Closed

doc: resolve ambiguity in pull-requests.md #28125

wants to merge 1 commit into from

Conversation

rexagod
Copy link
Contributor

@rexagod rexagod commented Jun 7, 2019

resolved ambiguous meanings for the term body of commit message
in pull-requests.md file

Fixes: #28068

Checklist

@nodejs-github-bot nodejs-github-bot added the doc label Jun 7, 2019
@Trott
Copy link
Member

@Trott Trott commented Jun 8, 2019

Left a few suggestions but they're totally optional as they address things that are already in the document rather than things that are introduced in this pull request.

@rexagod @Trott
doc: clarify commit message format in pull-requests.md
c1a93fd 
Resolved ambiguous meanings for the term `body of commit message`
in `pull-requests.md` file,

Fixes: nodejs#28068
Trott
Trott approved these changes Jun 9, 2019
View changes
@Trott Trott added the author ready label Jun 9, 2019
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jun 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23727/

@rexagod
Copy link
Contributor Author

@rexagod rexagod commented Jun 16, 2019

Pinging @trivikr to approve this if all seems fine, thanks!

@Trott
Copy link
Member

@Trott Trott commented Jun 16, 2019 •
edited

Landed in 558f834

@Trott Trott closed this Jun 16, 2019
Trott pushed a commit to Trott/io.js that referenced this issue Jun 16, 2019
@rexagod @Trott
doc: clarify commit message format in pull-requests.md
558f834 
Resolved ambiguous meanings for the term `body of commit message`
in `pull-requests.md` file,

Fixes: nodejs#28068
PR-URL: nodejs#28125
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this issue Jun 17, 2019
@rexagod @BridgeAR
doc: clarify commit message format in pull-requests.md
833d3d5 
Resolved ambiguous meanings for the term `body of commit message`
in `pull-requests.md` file,

Fixes: #28068
PR-URL: #28125
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this issue Jun 18, 2019
@rexagod @targos
doc: clarify commit message format in pull-requests.md
39b10ab 
Resolved ambiguous meanings for the term `body of commit message`
in `pull-requests.md` file,

Fixes: #28068
PR-URL: #28125
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@trivikr trivikr

Assignees
No one assigned
Labels
author ready doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: ambiguity in pull-requests.md
4 participants
@rexagod @Trott @nodejs-github-bot @trivikr