src: do not use pointer for loop in node_watchdog #28020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Jun 2, 2019
cjihrig
approved these changes
Jun 2, 2019
bnoordhuis
approved these changes
Jun 3, 2019
LGTM but is there a reason loop_ can't be an embedded uv_loop_t rather than a pointer-to-uv_loop_t?
This comment has been hidden.
This comment has been hidden.
|
@bnoordhuis Hm yeah, don’t know why I didn’t do that |
This comment has been hidden.
This comment has been hidden.
richardlau
approved these changes
Jun 9, 2019
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
jasnell
approved these changes
Jun 10, 2019
This comment has been hidden.
This comment has been hidden.
Trott
approved these changes
Jun 13, 2019
|
Landed in 25399e4 |
Trott
added a commit
to Trott/io.js
that referenced
this issue
Jun 13, 2019
PR-URL: nodejs#28020 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
added a commit
that referenced
this issue
Jun 17, 2019
PR-URL: #28020 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes