deps: update V8 to 7.6 #28016

ryzokuken · Jun 2, 2019

@cjihrig could you PTAL at 9106789?

ryzokuken · Jun 2, 2019

nodejs-github-bot · Jun 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23553/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2344/

targos · Jun 2, 2019

a05408b and d1e3650 are empty commits (just incrementing the embedder string) and can be removed

targos · Jun 2, 2019

There's an unhandled conflict here: 5a9af9b

targos · Jun 2, 2019

There are some unhandled conflicts here: bea6519

targos · Jun 2, 2019

@refack do you know how to handle this? 41ee4fb#diff-30246878345a874b2105006560a03f27R76

V8 code: https://github.com/v8/v8/blob/6e558e9e0973898cbad1b785478417395fde306c/BUILD.gn#L987-L989

nodejs-github-bot · Jun 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23554/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/

targos · Jun 2, 2019

@refack

13:34:47 PYTHONPATH=tools/pip python2 -m flake8 --count --show-source --statistics .
13:34:53 ./tools/v8_gypfiles/GN-scraper.py:23:46: F812 list comprehension redefines 'f' from line 10
13:34:53   rel_files = ['"%s/%s"' % (src_root, f) for f in files]
13:34:53                                              ^
13:34:53 1     F812 list comprehension redefines 'f' from line 10
13:34:53 1
13:34:53 gmake: *** [Makefile:1329: lint-py] Error 1

targos · Jun 2, 2019

@cjihrig Along with 9106789 (which I had to do to make it compile), we have some missing constants: v8dbg_class_FixedTypedArrayBase__base_pointer__Object,v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t,v8dbg_class_Map__instance_descriptors_offset

targos · Jun 2, 2019

@nodejs/platform-ppc @nodejs/platform-s390 we have some segfaults in V8 tests: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=ppcle-ubuntu1404,v8test=v8test/ https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=rhel72-s390x,v8test=v8test/

refack · Jun 2, 2019

F812 list comprehension redefines 'f' from line 10

We just need to rename the f... on it way.

miladfarca · Jun 2, 2019

s390 and ppc are segfaulting on some tests because of this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1632235, we have a solution but waiting on the original owner to get back to us on a question first.

nodejs-github-bot · Jun 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23570/

targos · Jun 2, 2019

😱 what happened to aix??

cjihrig · Jun 2, 2019

@cjihrig could you PTAL at 9106789?

Sure thing.

refack · Jun 2, 2019

😱 what happened to aix??

It get's that way from time to time.

nodejs-github-bot · Jun 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23572/

refack · Jun 2, 2019

😱 what happened to aix??

It get's that way from time to time.

What happened to the perma-yellow PPC (from test-worker-prof)? It seems to be green.

miladfarca · Jun 2, 2019

@refack the flaky test? might be an undefined behaviour where it passes or fails form time to time (due to this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1561072), will be looking into it using V8 master.

cjihrig · Jun 3, 2019

@ryzokuken / @targos can you try cherry-picking in cjihrig@19d7b31 and cjihrig@9e50c0a.

ryzokuken · Jun 3, 2019

@cjihrig @targos @refack fixed and done! PTAL. Making this PR ready for review. 🎉


      deps: V8: fix filename manipulation for Windows

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

Backport-PR-URL: #29241
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

Backport-PR-URL: #29241
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

Backport-PR-URL: #29241
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix filename manipulation for Windows

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: add workaround for MSVC optimizer bug

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>


      deps: V8: fix linking issue for MSVS

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

ryzokuken requested review from refack and targos Jun 2, 2019

targos force-pushed the ryzokuken:v8-7.6 branch 2 times, most recently from 28704ed to fe8bf54 Jun 2, 2019

targos added semver-major V8 Engine labels Jun 2, 2019

nodejs deleted a comment from nodejs-github-bot Jun 2, 2019

ryzokuken force-pushed the ryzokuken:v8-7.6 branch from 8e8a2c3 to ed3e45d Jun 3, 2019

ryzokuken marked this pull request as ready for review Jun 3, 2019

nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 14, 2019

nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 15, 2019

nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 16, 2019

nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 17, 2019

targos added a commit to targos/node that referenced this pull request Sep 17, 2019

targos added a commit that referenced this pull request Sep 19, 2019

targos added a commit that referenced this pull request Sep 20, 2019

nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 20, 2019

nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2019

nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 22, 2019

nodejs/node

Join GitHub today

deps: update V8 to 7.6 #28016

Conversation

ryzokuken commented Jun 2, 2019

ryzokuken requested review from refack and targos Jun 2, 2019

This comment has been minimized.

ryzokuken commented Jun 2, 2019

This comment was marked as outdated.

nodejs-github-bot commented Jun 2, 2019 • edited by targos

This comment was marked as resolved.

targos commented Jun 2, 2019

This comment was marked as resolved.

targos commented Jun 2, 2019

This comment was marked as resolved.

targos commented Jun 2, 2019

This comment was marked as resolved.

targos commented Jun 2, 2019

targos force-pushed the ryzokuken:v8-7.6 branch 2 times, most recently from 28704ed to fe8bf54 Jun 2, 2019

This comment has been minimized.

nodejs-github-bot commented Jun 2, 2019 • edited by targos

This comment was marked as resolved.

targos commented Jun 2, 2019

This comment has been minimized.

targos commented Jun 2, 2019

This comment has been minimized.

targos commented Jun 2, 2019

This comment was marked as resolved.

refack commented Jun 2, 2019

This comment has been minimized.

miladfarca commented Jun 2, 2019 • edited

This comment was marked as outdated.

nodejs-github-bot commented Jun 2, 2019

targos added semver-major V8 Engine labels Jun 2, 2019

This comment was marked as resolved.

targos commented Jun 2, 2019

This comment has been minimized.

cjihrig commented Jun 2, 2019

This comment has been minimized.

refack commented Jun 2, 2019

This comment was marked as outdated.

nodejs-github-bot commented Jun 2, 2019

nodejs deleted a comment from nodejs-github-bot Jun 2, 2019

This comment was marked as resolved.

refack commented Jun 2, 2019

This comment has been minimized.

miladfarca commented Jun 2, 2019 • edited

This comment has been minimized.

cjihrig commented Jun 3, 2019

ryzokuken force-pushed the ryzokuken:v8-7.6 branch from 8e8a2c3 to ed3e45d Jun 3, 2019

This comment has been minimized.

ryzokuken commented Jun 3, 2019

ryzokuken marked this pull request as ready for review Jun 3, 2019

nodejs-github-bot commented Jun 2, 2019 •

edited by targos

targos force-pushed the ryzokuken:v8-7.6 branch 2 times, most recently from `28704ed` to `fe8bf54` Jun 2, 2019

nodejs-github-bot commented Jun 2, 2019 •

edited by targos

miladfarca commented Jun 2, 2019 •

edited

miladfarca commented Jun 2, 2019 •

edited

ryzokuken force-pushed the ryzokuken:v8-7.6 branch from `8e8a2c3` to `ed3e45d` Jun 3, 2019