test: allow EAI_FAIL in test-http-dns-error.js #27500
Merged
+3
−5
Conversation
richardlau
approved these changes
Apr 30, 2019
Maybe consider printing the actual err.code in the cases where the assertions fail.
Trott
approved these changes
Apr 30, 2019
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22857/ EDIT(cjihrig): CI was yellow. |
EAI_FAIL is expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makes EAI_FAIL an acceptable error code on all platforms. PR-URL: nodejs#27500 Fixes: nodejs#27487 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
2 tasks
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
EAI_FAILis expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makesEAI_FAILan acceptable error code on all platforms.Fixes: #27487
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe text was updated successfully, but these errors were encountered: