★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27303Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix extname with the correct description #27303

Closed
wants to merge 1 commit into from
Closed

doc: fix extname with the correct description #27303

wants to merge 1 commit into from

Conversation

Himself65
Copy link
Member

@Himself65 Himself65 commented Apr 19, 2019

fix #27292

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc path labels Apr 19, 2019
@Himself65
Copy link
Member Author

@Himself65 Himself65 commented Apr 19, 2019 

doc/api/path.md
  160:73  warning  Remove trailing whitespace  no-trailing-spaces  remark-lint

Trott
Trott reviewed Apr 19, 2019
View changes
doc/api/path.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Apr 19, 2019
View changes
doc/api/path.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

@Trott Trott commented Apr 19, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3300/

@Himself65
Copy link
Member Author

@Himself65 Himself65 commented Apr 19, 2019 •
edited

have squashed

@Trott
Copy link
Member

@Trott Trott commented Apr 19, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3307/

@vsemozhetbyt vsemozhetbyt added the author ready label Apr 20, 2019
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Apr 20, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track label Apr 20, 2019
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Apr 20, 2019

Landed in 290faec
Thank you!

vsemozhetbyt pushed a commit that referenced this issue Apr 20, 2019
@Himself65 @vsemozhetbyt
doc: fix extname with the correct description
290faec 
PR-URL: #27303
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@BeniCheni BeniCheni

@BridgeAR BridgeAR

@vsemozhetbyt vsemozhetbyt

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready doc fast-track path
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path.extname('.a.a')!=''
7 participants
@Himself65 @Trott @vsemozhetbyt @BeniCheni @BridgeAR @ZYSzys @nodejs-github-bot