★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27216Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: bail vcbuild if mklink fails #27216

Merged
merged 1 commit into from Apr 20, 2019
Merged

build,win: bail vcbuild if mklink fails #27216

merged 1 commit into from Apr 20, 2019

Conversation

refack
Copy link
Member

@refack refack commented Apr 13, 2019

Refs: #27149 (comment)

Otherwise vcbuild will continue even if mklink fails, and will use old artifacts if present.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 13, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3243

@refack refack requested a review from richardlau Apr 13, 2019
@refack refack force-pushed the bail-vcbuild-if-mklink-fails branch from 772c4db to 1a39749 Compare Apr 13, 2019
refack
refack reviewed Apr 13, 2019
View changes
vcbuild.bat Outdated Show resolved Hide resolved
@nodejs nodejs deleted a comment from nodejs-github-bot Apr 13, 2019
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22412/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22414/

@refack refack self-assigned this Apr 13, 2019
@refack refack force-pushed the bail-vcbuild-if-mklink-fails branch from b09360b to b72f24e Compare Apr 14, 2019
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22431/

@refack
Copy link
Member Author

@refack refack commented Apr 14, 2019

/CC @nodejs/build-files @nodejs/platform-windows

@refack
build,win: bail vcbuild if mklink fails
0fc27f6 
PR-URL: nodejs#27216
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@refack refack force-pushed the bail-vcbuild-if-mklink-fails branch from b72f24e to 0fc27f6 Compare Apr 20, 2019
@refack refack merged commit 0fc27f6 into nodejs:master Apr 20, 2019
1 of 2 checks passed
@refack refack removed their assignment Apr 20, 2019
@refack refack deleted the bail-vcbuild-if-mklink-fails branch Apr 20, 2019
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau

Assignees
No one assigned
Labels
build windows
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@refack @nodejs-github-bot @richardlau