★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27166Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pin Python version in Travis #27166

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@thefourtheye thefourtheye

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready build python
Projects
None yet
Milestone
No milestone
5 participants
@richardlau @nodejs-github-bot @cclauss @BridgeAR @thefourtheye
@richardlau
Copy link
Member

commented Apr 10, 2019 •
edited

Travis will be switching the default version of Python from 2.7 to 3.6 on April 16th 2019.

This PR pins the Travis builds to Python 2.7 as we're not at Python 3 compatibility yet. If we can get there before April 16th we can drop this PR, otherwise it will be necessary for our Travis builds to continue to function.

Refs: https://changelog.travis-ci.com/upcoming-python-default-version-update-96873

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau richardlau added the work in progress (WIP) label Apr 10, 2019

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
Copy link

commented Apr 10, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3222

@nodejs-github-bot nodejs-github-bot added the build label Apr 10, 2019

@richardlau richardlau force-pushed the richardlau:travispython3 branch 3 times, most recently from 125b805 to a2cc894 Apr 10, 2019

@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 10, 2019

Some notes:
So the Travis documented way of pinning the Python version:

language: python
python: '2.7'

doesn't work for non-Python projects such as ours. The Xenial images on Travis have Python 2.7.15, 3.6.7, and 3.7.1: https://docs.travis-ci.com/user/reference/xenial/#python-support
Used pyenv to switch to 3.6.7 and the compilation jobs fail because we haven't updated configure which specifically looks for a Python 2 to reexecute itself (fix pending in #25878).

So we do need to pin to 2.7.15 in the short term. Updating this PR...

@richardlau richardlau force-pushed the richardlau:travispython3 branch from a2cc894 to 7da1e40 Apr 10, 2019

@richardlau richardlau changed the title WIP build: pin Python version in Travis build: pin Python version in Travis Apr 10, 2019

@richardlau richardlau added python and removed work in progress (WIP) labels Apr 10, 2019

@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 10, 2019

According to https://changelog.travis-ci.com/upcoming-python-default-version-update-96873

On April 16th 2019, the default Python version used to run your builds will be updated from Python 2.7 to Python 3.6

This PR pins the Travis builds to Python 2.7 as we're not at Python 3 compatibility yet. If we can get there before April 16th we can drop this PR, otherwise it will be necessary for our Travis builds to continue to function.

cc FYI @nodejs/python @cclauss

This was referenced Apr 10, 2019

Closed
Closed
@thefourtheye

thefourtheye approved these changes Apr 10, 2019
View changes

@cclauss

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 10, 2019

Relates to travis-ci/travis-build#1678
@cclauss

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 10, 2019

We have a list of things to get done... #25789. What percentage of build machine have Python 3 loaded?
@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 10, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3223/

@richardlau richardlau added the author ready label Apr 10, 2019

@richardlau
build: pin Python version in Travis 
Travis will be switching the default version of Python from 2.7 to 3.6.
Our configuration and build scripts are not quite ready for Python 3
yet, so pin the version of Python to 2.7.
Loading status checks…
1fbe324

@richardlau richardlau force-pushed the richardlau:travispython3 branch from 7da1e40 to 1fbe324 Apr 12, 2019

@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 12, 2019

Fixed merge conflicts.

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3239/
@BridgeAR

BridgeAR approved these changes Apr 15, 2019
View changes

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 15, 2019

@richardlau @BridgeAR
build: pin Python version in Travis 
Travis will be switching the default version of Python from 2.7 to 3.6.
Our configuration and build scripts are not quite ready for Python 3
yet, so pin the version of Python to 2.7.

PR-URL: nodejs#27166
Refs: https://changelog.travis-ci.com/upcoming-python-default-version-update-96873
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
b468a1d
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 15, 2019

Landed in b468a1d 🎉

@BridgeAR BridgeAR closed this Apr 15, 2019

@richardlau richardlau deleted the richardlau:travispython3 branch Apr 15, 2019

This was referenced Apr 23, 2019

Closed
Closed
Closed

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.