★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27159Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: remove trace frame #27159

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@eugeneo eugeneo

@ChALkeR ChALkeR

@jasnell jasnell

@lpinca lpinca

@targos targos

@richardlau richardlau

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready console
Projects
None yet
Milestone
No milestone
9 participants
@BridgeAR @nodejs-github-bot @ZYSzys @eugeneo @ChALkeR @jasnell @lpinca @targos @richardlau
@BridgeAR
Copy link
Member

commented Apr 9, 2019

The own function's frame was removed originally. This restors that
behavior.

Fixes: #27134

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@BridgeAR
console: remove trace frame 
The own function's frame was removed originally. This restors that
behavior.

Fixes: #27134
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
4b1cb41
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 9, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3216

@nodejs-github-bot nodejs-github-bot added the console label Apr 9, 2019

@eugeneo

eugeneo approved these changes Apr 9, 2019
View changes

@richardlau

richardlau approved these changes Apr 9, 2019
View changes

Copy link
Member

left a comment

Commit message has a typo (restors).
@targos

targos approved these changes Apr 9, 2019
View changes

lib/internal/console/constructor.js
@@ -330,13 +330,13 @@ const consoleMethods = {
trace(kTraceInstant, kTraceConsoleCategory, `time::${label}`, 0);
},

trace(...args) {
trace: function trace(...args) {

This comment has been minimized.

Sign in to view
Copy link
@targos

targos Apr 9, 2019

Member

Is this strictly needed? I thought the shorthand notation had the same behavior.

This comment has been minimized.

Sign in to view
Copy link
@BridgeAR

BridgeAR Apr 10, 2019

Author Member

With the shorthand notation, the function would be called as obj.property. It is not possible to access the function itself by only using the property name. That is only possible inside the old function foo type.

It would also be possible if this would not be a property but a variable.

@BridgeAR BridgeAR closed this Apr 10, 2019

@BridgeAR BridgeAR reopened this Apr 10, 2019

@jasnell

jasnell approved these changes Apr 10, 2019
View changes

@BridgeAR BridgeAR added the author ready label Apr 10, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22346/
@ZYSzys

ZYSzys approved these changes Apr 10, 2019
View changes

@lpinca

lpinca approved these changes Apr 10, 2019
View changes

@ChALkeR

ChALkeR approved these changes Apr 10, 2019
View changes

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22386/
@ZYSzys

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 12, 2019

Landed in 091902a 🎉

@ZYSzys ZYSzys closed this Apr 12, 2019

targos pushed a commit to targos/node that referenced this pull request Apr 12, 2019

@BridgeAR @ZYSzys
console: remove trace frame 
The own function's frame was removed originally. This restors that
behavior.

Fixes: nodejs#27134

PR-URL: nodejs#27159
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
091902a

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.