★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27094Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-benchmark-module #27094

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@bengl bengl

@danbev danbev

Assignees
No one assigned
Labels
author ready fast-track test
Projects
None yet
Milestone
No milestone
4 participants
@Trott @nodejs-github-bot @bengl @danbev
@Trott
Copy link
Member

commented Apr 4, 2019

A recent commit broke test-benchmark-module. This fixes it.

Culprit is #26970.

Collaborators, please 👍 here if you approve fast-tracking.

@BridgeAR @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
test: fix test-benchmark-module 
A recent commit broke test-benchmark-module. This fixes it.

Culprit is #26970.
Loading status checks…
ab04470

@Trott Trott added the fast-track label Apr 4, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 4, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3173

@nodejs-github-bot nodejs-github-bot added the test label Apr 4, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 4, 2019 •
edited

Benchmark test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5972/ ✅
@danbev

danbev approved these changes Apr 5, 2019
View changes

@Trott Trott added the author ready label Apr 5, 2019

@bengl

bengl approved these changes Apr 5, 2019
View changes

Trott added a commit to Trott/io.js that referenced this pull request Apr 5, 2019

@Trott
test: fix test-benchmark-module 
A recent commit broke test-benchmark-module. This fixes it.

PR-URL: nodejs#27094
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
c86883c
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 5, 2019

Landed in c86883c

@Trott Trott closed this Apr 5, 2019

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.