★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/27074Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: fix custom inspection with extra properties #27074

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@targos targos

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready buffer util
Projects
None yet
Milestone
No milestone
5 participants
@BridgeAR @nodejs-github-bot @danbev @targos @ZYSzys
@BridgeAR
Copy link
Member

commented Apr 3, 2019

This broke due to a recent change that prevents exposing inspect
internals. It now relies on the public API instead and should be a
bit more "robust" due to that (it's still bad but I see no good alternative :D).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@BridgeAR
buffer: fix custom inspection with extra properties 
This broke due to a recent change that prevents exposing inspect
internals. It now relies on the public API instead and should be a
bit more robust due to that.
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
a338495
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 3, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3157

@nodejs-github-bot nodejs-github-bot added buffer util labels Apr 3, 2019

@BridgeAR BridgeAR requested a review from targos Apr 3, 2019

@targos

targos approved these changes Apr 3, 2019
View changes

@BridgeAR BridgeAR added the author ready label Apr 3, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Apr 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22180/
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 5, 2019

@nodejs/util @nodejs/buffer PTAL
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 7, 2019

This could use another review :)
@ZYSzys

ZYSzys reviewed Apr 7, 2019
View changes

Show resolved Hide resolved lib/buffer.js
@ZYSzys

ZYSzys approved these changes Apr 8, 2019
View changes

danbev added a commit to danbev/node that referenced this pull request Apr 8, 2019

@BridgeAR @danbev
buffer: fix custom inspection with extra properties 
This broke due to a recent change that prevents exposing inspect
internals. It now relies on the public API instead and should be a
bit more robust due to that.

PR-URL: nodejs#27074
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
d834275
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 8, 2019

Landed in d834275.

@danbev danbev closed this Apr 8, 2019

This was referenced Apr 23, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.