Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbuild: don't use lint-ci on Travis #27062
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
build
label
Apr 2, 2019
richardlau
requested a review
from refack
Apr 2, 2019
This comment has been minimized.
This comment has been minimized.
|
If it was just the case of the linter failure not being visible we could echo the tap file in the |
refack
approved these changes
Apr 2, 2019
BridgeAR
approved these changes
Apr 3, 2019
BridgeAR
added
the
author ready
label
Apr 3, 2019
mihalskiy
approved these changes
Apr 3, 2019
richardlau
force-pushed the
richardlau:travislint
branch
from
5ead90b
to
af03de4
Apr 5, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in af03de4. |
richardlau
merged commit af03de4
into
nodejs:master
Apr 5, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
richardlau commentedApr 2, 2019
The
lint-ciMakefile target differs fromlintin that it writes toa tap file and not stdout and also stops execution when an error is
found (e.g. if JavaScript linting fails the C++ and docs linting are
not run).
The switch to
lint-ciwas to enable Python linting. Revert tolintand add the
lint-pytarget.Example Travis run where
lintis used (note that C++ and docs linting occur after the JavaScript linter fails):https://travis-ci.com/nodejs/node/jobs/189665652
Example Travis run where
lint-ciis used (note that C++ and docs linting are not attempted after JavaScript linter fails and the actual linter failure is not visible):https://travis-ci.com/nodejs/node/jobs/189720838
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes