★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26753Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing pr-url #26753

Closed
wants to merge 1 commit into from
Closed

doc: add missing pr-url #26753

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 18, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 18, 2019

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2973/pipeline

@nodejs-github-bot nodejs-github-bot added deprecations doc labels Mar 18, 2019
@targos targos added the fast-track label Mar 18, 2019
@targos
Copy link
Member

@targos targos commented Mar 18, 2019

👍 this comment if you approve fast-tracking

@vsemozhetbyt vsemozhetbyt added the author ready label Mar 18, 2019
@danbev
Copy link
Member

@danbev danbev commented Mar 19, 2019

CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2980/

@danbev
Copy link
Member

@danbev danbev commented Mar 19, 2019

Landed in cd9898a.

@danbev danbev closed this Mar 19, 2019
danbev pushed a commit that referenced this issue Mar 19, 2019
@cjihrig @danbev
doc: add missing pr-url
cd9898a 
PR-URL: #26753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@cjihrig cjihrig deleted the dep-fix branch Mar 19, 2019
@targos targos added this to Don't land (ever) in v11.x Mar 27, 2019
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@lpinca lpinca

@targos targos

@richardlau richardlau

@vsemozhetbyt vsemozhetbyt

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready deprecations doc fast-track
Projects
No open projects
v11.x
  
Don't land (ever)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@cjihrig @nodejs-github-bot @targos @danbev @jasnell @addaleax @lpinca @richardlau @vsemozhetbyt @ZYSzys