★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26737Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: optimize test-http2-large-file #26737

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@mcollina mcollina

@edsadr edsadr

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready http2 test
Projects
None yet
Milestone
No milestone
5 participants
@Trott @nodejs-github-bot @mcollina @edsadr @ZYSzys
@Trott
Copy link
Member

Trott commented Mar 18, 2019

Optimize test-http2-large-file so it only allocates a single buffer.

I don't expect that this will resolve #22327, but one small change at a time....

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
test: optimize test-http2-large-file 
Optimize test-http2-large-file so it only allocates a single buffer.
Loading status checks…
d4933c6
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Mar 18, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21622/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 18, 2019

Again, I don't expect this to fix the test flakiness, but hey, let's check, and let's at least make sure it doesn't make things obviously worse....

Stress test on master using a Rackspace host: https://ci.nodejs.org/job/node-stress-single-test/2165/nodes=win2008r2-vs2017/

Stress test on this PR using a Rackspace host: https://ci.nodejs.org/job/node-stress-single-test/2166/

(The test failures in #22327 only seem to happen on Rackspace + Win 2008 R2, at least recently.)

@Trott Trott added the http2 label Mar 18, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 19, 2019

Sorry to ping but I was hoping to get a review or two by now? @nodejs/http2 @nodejs/testing
@mcollina

mcollina approved these changes Mar 19, 2019
View changes

Copy link
Member

mcollina left a comment

LGTM
@ZYSzys

ZYSzys approved these changes Mar 19, 2019
View changes

@Trott Trott added the author ready label Mar 19, 2019

@edsadr

edsadr approved these changes Mar 20, 2019
View changes

Copy link
Member

edsadr left a comment

LGTM
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 20, 2019 •
edited

Landed in ba1c5ff.

@Trott Trott closed this Mar 20, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 20, 2019

@Trott
test: optimize test-http2-large-file 
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
ba1c5ff

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@Trott @targos
test: optimize test-http2-large-file 
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
416797c

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@Trott @targos
test: optimize test-http2-large-file 
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
1882f97

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@Trott @targos
test: optimize test-http2-large-file 
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
d3d80aa

targos added a commit that referenced this pull request Mar 27, 2019

@Trott @targos
test: optimize test-http2-large-file 
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: #26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
7ebd6bd

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.