★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26630Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove usage of deprecated IsNearDeath #26630

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@addaleax addaleax

@cjihrig cjihrig

@tniessen tniessen

@joyeecheung joyeecheung

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
C++ author ready
Projects
None yet
Milestone
No milestone
9 participants
@targos @nodejs-github-bot @bnoordhuis @jasnell @addaleax @cjihrig @tniessen @joyeecheung @BridgeAR
@targos
Copy link
Member

targos commented Mar 13, 2019

Refs: v8/v8@06193b0
@targos
src: remove usage of deprecated IsNearDeath 
Refs: v8/v8@06193b0
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
66bf9fa
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the C++ label Mar 13, 2019

@joyeecheung

joyeecheung approved these changes Mar 13, 2019
View changes

@addaleax

addaleax approved these changes Mar 13, 2019
View changes

@bnoordhuis

bnoordhuis approved these changes Mar 13, 2019
View changes

@BridgeAR

BridgeAR approved these changes Mar 13, 2019
View changes

@cjihrig

cjihrig approved these changes Mar 13, 2019
View changes

@tniessen

tniessen approved these changes Mar 13, 2019
View changes

@jasnell

jasnell approved these changes Mar 13, 2019
View changes

@targos

This comment has been minimized.

Sign in to view
Copy link
Member Author

targos commented Mar 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21503/

@targos targos added the author ready label Mar 13, 2019

@Flarna Flarna referenced this pull request Mar 15, 2019

Merged

remove usage of deprecated IsNearDeath #842

@targos

This comment has been minimized.

Sign in to view
Copy link
Member Author

targos commented Mar 15, 2019

Landed in c32615c

@targos targos closed this Mar 15, 2019

@targos targos deleted the targos:no-isneardeath branch Mar 15, 2019

targos added a commit that referenced this pull request Mar 15, 2019

@targos
src: remove usage of deprecated IsNearDeath 
Refs: v8/v8@06193b0

PR-URL: #26630
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
c32615c

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

@targos @Drieger
src: remove usage of deprecated IsNearDeath 
Refs: v8/v8@06193b0

PR-URL: nodejs#26630
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
4392be4

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@targos
src: remove usage of deprecated IsNearDeath 
Refs: v8/v8@06193b0

PR-URL: nodejs#26630
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
1bfcf50

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@targos
src: remove usage of deprecated IsNearDeath 
Refs: v8/v8@06193b0

PR-URL: nodejs#26630
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
1fd5995

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@targos
src: remove usage of deprecated IsNearDeath 
Refs: v8/v8@06193b0

PR-URL: nodejs#26630
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
4bf7138

targos added a commit that referenced this pull request Mar 27, 2019

@targos
src: remove usage of deprecated IsNearDeath 
Refs: v8/v8@06193b0

PR-URL: #26630
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
925b645

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.