★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26543Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix nits in writing-tests.md #26543

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@addaleax addaleax

@lpinca lpinca

Assignees
No one assigned
Labels
author ready doc fast-track test
Projects
None yet
Milestone
No milestone
4 participants
@vsemozhetbyt @nodejs-github-bot @addaleax @lpinca
@vsemozhetbyt
Copy link
Member

vsemozhetbyt commented Mar 9, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Correct a typo.
  • Normalize spaces.
  • Split a paragraph with different topics.
@vsemozhetbyt
doc: fix nits in writing-tests.md 
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.
Loading status checks…
7e72b91
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the doc label Mar 9, 2019

@vsemozhetbyt vsemozhetbyt added the test label Mar 9, 2019

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Mar 9, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
@addaleax

addaleax approved these changes Mar 9, 2019
View changes

@lpinca

lpinca approved these changes Mar 9, 2019
View changes

@vsemozhetbyt vsemozhetbyt added fast-track author ready labels Mar 9, 2019

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Mar 9, 2019

Landed in 4e9dc31
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt closed this Mar 9, 2019

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-test-console branch Mar 9, 2019

vsemozhetbyt added a commit that referenced this pull request Mar 9, 2019

@vsemozhetbyt
doc: fix nits in writing-tests.md 
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Loading status checks…
4e9dc31

BridgeAR added a commit that referenced this pull request Mar 13, 2019

@vsemozhetbyt @BridgeAR
doc: fix nits in writing-tests.md 
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
a2511f8

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@vsemozhetbyt @BridgeAR
doc: fix nits in writing-tests.md 
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
693505b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.